Recommend pointing binary-path at /deps #1014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in a significant speed-up since we can avoid invoking `llvm-cov export` on all the object files in `target/debug/incremental`. See mozilla#1013.
Collaborator
|
Given that we risk missing something by doing this, I would not recommend it by default in all examples in the README, but just add a note saying that it can improve performance |
Contributor
Author
|
It doesn't sound like it actually misses coverage if the reported coverage for build scripts is 100% anyway though (at least that was what one report said). But happy to update this to be a note about it improving performance instead if you'd prefer? |
Collaborator
|
From #1015 (comment) it looks like build.rs files were not covered? |
sandesh3407
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results in a significant speed-up since we can avoid invoking
llvm-cov exporton all the object files intarget/debug/incremental.See #1013.