Populate condition-coverage field in cobertura xml reports
#1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silven
force-pushed
the
silven/cobertura
branch
2 times, most recently
from
fcd10f9 to
6d22c48
Compare
Contributor
Author
|
Interesting side note I learned about when investigating this. Since GCC 14, there is actual support for condition coverage - but it involves a new version of the gcov file format, which grcov doesn't support. |
This comment was marked as outdated.
This comment was marked as outdated.
silven
force-pushed
the
silven/cobertura
branch
2 times, most recently
from
6d0d1ea to
a610f8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
silven
force-pushed
the
silven/cobertura
branch
2 times, most recently
from
b661e7d to
3d15f5a
Compare
Contributor
Author
|
Sorry for the repeated ping @marco-c, any thoughts on this? |
Contributor
Author
|
Any maintainer available for input / code review? |
marco-c
reviewed
Nov 7, 2025
marco-c
reviewed
Nov 7, 2025
silven
force-pushed
the
silven/cobertura
branch
3 times, most recently
from
581eb0e to
118bfe8
Compare
marco-c
reviewed
Nov 10, 2025
silven
force-pushed
the
silven/cobertura
branch
from
118bfe8 to
fae5021
Compare
Some parsers require the presence of the `condition-coverage` field on the `line` elements in the report. This change adds and populates this field based on the available `Conditions` data. See: https://github.com/cobertura/cobertura/blob/master/cobertura/src/site/htdocs/xml/coverage-03.dtd Implements mozilla#1029
silven
force-pushed
the
silven/cobertura
branch
from
fae5021 to
1088aba
Compare
marco-c
approved these changes
Nov 14, 2025
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parsers require the presence of the
condition-coveragefield on thelineelements in the report. This change adds and populates this field based on the availableConditionsdata.See: https://github.com/cobertura/cobertura/blob/master/cobertura/src/site/htdocs/xml/coverage-03.dtd
Implements / Addresses #1029
I don't know if this is entirely correct, but it is accepted by our SonarQube setup at least.