Skip to content

Return a non-0 exit code in case of errors that should not be ignored #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Return a non-0 exit code in case of errors that should not be ignored #842

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78c145b
Return a non-0 exit code in case of errors that should not be ignored
marco-c Jun 11, 2022
b69de69
Merge branch 'master' into exitcode
calixteman Sep 11, 2022
f1b7bf3
Merge branch 'master' into exitcode
calixteman Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,7 @@ pub fn consumer(
ItemType::Path((stem, gcno_path)) => {
// GCC
if let Err(e) = run_gcov(&gcno_path, branch_enabled, working_dir) {
error!("Error when running gcov: {}", e);
continue;
panic!("Error when running gcov: {}", e);
};
let gcov_ext = get_gcov_output_ext();
let gcov_path =
Expand Down Expand Up @@ -267,19 +266,16 @@ pub fn consumer(
}
}
ItemType::Content(_) => {
error!("Invalid content type");
continue;
panic!("Invalid content type");
}
ItemType::Paths(_) => {
error!("Invalid content type");
continue;
panic!("Invalid content type");
}
}
}
ItemFormat::Profraw => {
if binary_path.is_none() {
error!("The path to the compiled binary must be given as an argument when source-based coverage is used");
continue;
panic!("The path to the compiled binary must be given as an argument when source-based coverage is used");
}

if let ItemType::Paths(profraw_paths) = work_item.item {
Expand All @@ -301,13 +297,11 @@ pub fn consumer(
new_results
}
Err(e) => {
error!("Error while executing llvm tools: {}", e);
continue;
panic!("Error while executing llvm tools: {}", e);
}
}
} else {
error!("Invalid content type");
continue;
panic!("Invalid content type");
}
}
ItemFormat::Info | ItemFormat::JacocoXml => {
Expand All @@ -319,8 +313,7 @@ pub fn consumer(
try_parse!(parse_jacoco_xml_report(buffer), work_item.name)
}
} else {
error!("Invalid content type");
continue;
panic!("Invalid content type");
}
}
};
Expand Down