Skip to content

Conversation

@kik-kik
Copy link
Contributor

@kik-kik kik-kik commented Dec 15, 2025

feat: delete definitions related to focus_android, focus_ios, klar_android, and klar_ios

The DAU related metrics should still be available via mobile_active_users_aggregates_view data source.

@kik-kik kik-kik self-assigned this Dec 15, 2025
@kik-kik kik-kik requested a review from scholtzan as a code owner December 15, 2025 17:49
@kik-kik kik-kik requested a review from bochocki December 15, 2025 17:49
@scholtzan
Copy link
Collaborator

The definitions/ and opmon/ files should not be deleted, only what's in looker/. definitions/ and opmon/ files are used for experiments and opmon projects.

@kik-kik kik-kik force-pushed the feat/delete-klar_ios-klar_android-focus_ios-focus_android-definitions branch from 5361464 to 3ea2f1f Compare December 15, 2025 17:58
Copy link
Collaborator

@scholtzan scholtzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated views/explores haven't been used based on our Looker usage audit. So should be fine to delete them

@kik-kik kik-kik added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit d528179 Dec 16, 2025
6 checks passed
@kik-kik kik-kik deleted the feat/delete-klar_ios-klar_android-focus_ios-focus_android-definitions branch December 16, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants