Make BoxType, BoxHeader, BMFFBox, BoxIter, and read_moov pub #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinetiknz
approved these changes
May 26, 2025
Collaborator
kinetiknz
left a comment
kinetiknz
left a comment
There was a problem hiding this comment.
Thanks, seems reasonable.
Collaborator
|
Landed via 761f8d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oftentimes, it would be nice to be able to start playing an MP4 file before it's available in its entirety, e.g. because it's streamed over a network connection.
In these cases,
read_mp4fails, because it always tries to read every box it finds as far as I could tell.However, since
moovis the main info box that contains track info, etc, at the minimum this has to be parsed before attempting to decode samples (frames) in a streaming fashion.There even is a hint in a comment in the code about this:
"found moov {}, could stop pure 'moov' parser now"Making these items public facilitates such a use case.
Something like this will be necessary for ruffle-rs/ruffle#14655.