Show error message and troubleshooting steps on contextual identities error#2598
Open
brizental wants to merge 1 commit intomozilla:mainfrom
Open
Show error message and troubleshooting steps on contextual identities error#2598brizental wants to merge 1 commit intomozilla:mainfrom
brizental wants to merge 1 commit intomozilla:mainfrom
Conversation
Collaborator
You can open a PR on the upstream l10n repository and simply mention that it depends on this PR to be merged.
Looks good to me. |
dannycolin
reviewed
Nov 29, 2023
|
|
||
| /* ----- Error ---------- */ | ||
|
|
||
| #on-error { |
Collaborator
There was a problem hiding this comment.
nitpick: I think we could use more obvious like containers-pref-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
This is just a suggestion. See screenshot of what the error looks like:
Two things:
Type of change
Tag issues related to this pull request: