Fix reordering for KDE, and dragging to the end#2729
Open
hirak99 wants to merge 1 commit intomozilla:mainfrom
Open
Fix reordering for KDE, and dragging to the end#2729hirak99 wants to merge 1 commit intomozilla:mainfrom
hirak99 wants to merge 1 commit intomozilla:mainfrom
Conversation
Fixes mozilla#2705 - The drag-drop API does not work on this extension under KDE. Switching over to mouse events retains this ability, and works under KDE. Note: I have note tested outside KDE. Fixes mozilla#2665 - In addition, this also fixes the issue of moving to the end.
ranjan-purbey
approved these changes
Apr 4, 2025
Contributor
ranjan-purbey
left a comment
ranjan-purbey
left a comment
There was a problem hiding this comment.
It seems that elements inside web-extension popup windows do not receive dragover or drop events in firefox running in a KDE wayland session. So using mouse events as a workaround seems good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
Please include a summary of the changes including relevant motivation and context.
Fixes #2705 -
The drag-drop API does not work on this extension under KDE. Switching over to mouse events retains this ability, and works under KDE. Note: I have note tested outside KDE.
Fixes #2665 -
In addition, this also fixes the issue of moving to the end.
Demo video -
screencast_multi_user_container_reorder_fix.mp4
Type of change
Select all that apply.
Tag issues related to this pull request:
#2705, #2665