Feature / bug fix: popup: open tab counters, lists, tab moving now work with tabs in non-current tabs#2880
Open
FNCheng137 wants to merge 1 commit intomozilla:mainfrom
Open
Feature / bug fix: popup: open tab counters, lists, tab moving now work with tabs in non-current tabs#2880FNCheng137 wants to merge 1 commit intomozilla:mainfrom
FNCheng137 wants to merge 1 commit intomozilla:mainfrom
Conversation
…abs in non-current windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
When using open tab counts and lists, the current behavior of this add-on is to count or list only relevant tabs in the focused window. For example, if a tab in a container is open in one window and when the popup menu is opened in another window, the open tab counter displays none and the list shows no tabs.
When a large number of tabs are opened in two or three windows, normally one would intuitively expect the counter and the list to count or list tabs in any window when finding open tabs. This behavior is counter-intuitive, misleading, and bad for usability.
Also this may harm privacy when the goal is to close all tabs before clearing site data.
Change
The counter now counts all tabs in all windows. The list now has a section for "Open Tabs in Other Windows". Now the move tabs to new window function can move tabs from all windows.
Breaking
L10n needs two new entries, namely
Open Tabs in Other WindowsandMove Tabs in All Windows to a Single Window. See PR in l10n repo mozilla-l10n/multi-account-containers-l10n#32.Screenshot
Type of change
Select all that apply.
I personally consider the previous behavior a bug.
Tag issues related to this pull request:
Closing: #2159, #2878 (duplicate)