options: Make form controls respect color scheme#2884
Open
ator-dev wants to merge 1 commit intomozilla:mainfrom
Open
options: Make form controls respect color scheme#2884ator-dev wants to merge 1 commit intomozilla:mainfrom
ator-dev wants to merge 1 commit intomozilla:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testand all tests passed.I don't think this needs to be tested; it's only aesthetic.
Description
Every time I used the options I had the feeling something was off with the colours, and I just realised what it is. The
color-schemeproperty isn't set, so the form controls default to light theme even if everything else is dark! I have set it tolight darkat the root level, which means all UI chrome respects the user's colour preference, with "light" being the default.https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/color-scheme
Type of change
Tag issues related to this pull request:
None (I think)