chore: Script to update deps to what Gecko has#2930
Merged
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
And add a helper script to make that somewhat easier.
larseggert
force-pushed
the
chore-bump-deps
branch
from
218a998 to
ed2957a
Compare
Collaborator
Author
|
Seems this is blocked until we can get rid of the MSRV-pinning to 1.81. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2930 +/- ##
==========================================
- Coverage 93.41% 93.37% -0.04%
==========================================
Files 124 124
Lines 36178 36178
Branches 36178 36178
==========================================
- Hits 33795 33782 -13
- Misses 1537 1549 +12
- Partials 846 847 +1
|
mxinden
reviewed
Sep 2, 2025
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Oh wonderful, how did you stumble over https://github.com/graydon/check-lockfile-intersection ?
Collaborator
Author
Google :-) |
Member
|
🤯 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a helper script to automate dependency version synchronization with Gecko's Cargo.lock file. This script uses an external tool to compare lockfiles and generate cargo update commands for alignment.
- Introduces a bash script to streamline dependency updates to match Gecko versions
- Implements filtering logic to exclude problematic packages that require manual handling
- Automates the generation of precise cargo update commands
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Bencher Report| Branch | chore-bump-deps |
| Testbed | On-prem |
🚨 2 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| decode 1048576 bytes, mask 3f | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 1.76 ms(+9.89%)Baseline: 1.60 ms | 1.69 ms (104.19%) |
| decode 1048576 bytes, mask 7f | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 5.10 ms(+0.80%)Baseline: 5.06 ms | 5.09 ms (100.19%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client | 📈 view plot 🚷 view threshold | 204,510,000.00 ns(-1.55%)Baseline: 207,736,986.30 ns | 218,063,879.06 ns (93.78%) |
| 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client | 📈 view plot 🚷 view threshold | 197,740,000.00 ns(-1.97%)Baseline: 201,712,191.78 ns | 212,866,620.65 ns (92.89%) |
| 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client | 📈 view plot 🚷 view threshold | 28,525,000.00 ns(+0.34%)Baseline: 28,427,694.06 ns | 28,849,570.70 ns (98.87%) |
| 1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client | 📈 view plot 🚷 view threshold | 281,490,000.00 ns(-3.95%)Baseline: 293,062,648.40 ns | 306,306,274.62 ns (91.90%) |
| 1-streams/each-1000-bytes/simulated-time | 📈 view plot 🚷 view threshold | 119,010,000.00 ns(+0.47%)Baseline: 118,457,168.95 ns | 120,869,918.94 ns (98.46%) |
| 1-streams/each-1000-bytes/wallclock-time | 📈 view plot 🚷 view threshold | 592,050.00 ns(-0.68%)Baseline: 596,120.82 ns | 621,041.03 ns (95.33%) |
| 1000-streams/each-1-bytes/simulated-time | 📈 view plot 🚷 view threshold | 14,994,000,000.00 ns(+0.01%)Baseline: 14,992,383,561.64 ns | 15,010,622,116.20 ns (99.89%) |
| 1000-streams/each-1-bytes/wallclock-time | 📈 view plot 🚷 view threshold | 13,718,000.00 ns(-2.89%)Baseline: 14,126,465.75 ns | 14,955,952.75 ns (91.72%) |
| 1000-streams/each-1000-bytes/simulated-time | 📈 view plot 🚷 view threshold | 18,959,000,000.00 ns(+0.11%)Baseline: 18,937,575,342.47 ns | 19,209,419,009.59 ns (98.70%) |
| 1000-streams/each-1000-bytes/wallclock-time | 📈 view plot 🚷 view threshold | 48,654,000.00 ns(-5.78%)Baseline: 51,637,584.47 ns | 58,255,784.66 ns (83.52%) |
| RxStreamOrderer::inbound_frame() | 📈 view plot 🚷 view threshold | 108,790,000.00 ns(-0.83%)Baseline: 109,695,707.76 ns | 111,843,245.10 ns (97.27%) |
| coalesce_acked_from_zero 1+1 entries | 📈 view plot 🚷 view threshold | 88.62 ns(+0.02%)Baseline: 88.60 ns | 89.26 ns (99.28%) |
| coalesce_acked_from_zero 10+1 entries | 📈 view plot 🚷 view threshold | 105.47 ns(-0.57%)Baseline: 106.07 ns | 107.07 ns (98.50%) |
| coalesce_acked_from_zero 1000+1 entries | 📈 view plot 🚷 view threshold | 89.18 ns(-0.70%)Baseline: 89.82 ns | 94.27 ns (94.61%) |
| coalesce_acked_from_zero 3+1 entries | 📈 view plot 🚷 view threshold | 105.83 ns(-0.70%)Baseline: 106.57 ns | 107.55 ns (98.40%) |
| decode 1048576 bytes, mask 3f | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 1,759,400.00 ns(+9.89%)Baseline: 1,601,111.42 ns | 1,688,712.71 ns (104.19%) |
| decode 1048576 bytes, mask 7f | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 5,100,500.00 ns(+0.80%)Baseline: 5,059,877.63 ns | 5,090,728.28 ns (100.19%) |
| decode 1048576 bytes, mask ff | 📈 view plot 🚷 view threshold | 3,015,800.00 ns(-0.51%)Baseline: 3,031,153.88 ns | 3,045,148.02 ns (99.04%) |
| decode 4096 bytes, mask 3f | 📈 view plot 🚷 view threshold | 5,557.30 ns(-31.88%)Baseline: 8,157.79 ns | 9,566.39 ns (58.09%) |
| decode 4096 bytes, mask 7f | 📈 view plot 🚷 view threshold | 19,482.00 ns(-2.48%)Baseline: 19,977.18 ns | 20,291.15 ns (96.01%) |
| decode 4096 bytes, mask ff | 📈 view plot 🚷 view threshold | 10,626.00 ns(-8.89%)Baseline: 11,663.18 ns | 12,265.12 ns (86.64%) |
| sent::Packets::take_ranges | 📈 view plot 🚷 view threshold | 4,498.30 ns(-5.15%)Baseline: 4,742.41 ns | 4,984.60 ns (90.24%) |
| transfer/pacing-false/same-seed/simulated-time/run | 📈 view plot 🚷 view threshold | 25,710,000,000.00 ns(+1.47%)Baseline: 25,337,142,857.14 ns | 25,952,933,788.09 ns (99.06%) |
| transfer/pacing-false/same-seed/wallclock-time/run | 📈 view plot 🚷 view threshold | 25,740,000.00 ns(-0.79%)Baseline: 25,944,811.06 ns | 27,025,636.25 ns (95.24%) |
| transfer/pacing-false/varying-seeds/simulated-time/run | 📈 view plot 🚷 view threshold | 25,181,000,000.00 ns(+0.04%)Baseline: 25,170,161,290.32 ns | 25,218,341,792.16 ns (99.85%) |
| transfer/pacing-false/varying-seeds/wallclock-time/run | 📈 view plot 🚷 view threshold | 25,153,000.00 ns(-3.57%)Baseline: 26,084,898.62 ns | 27,595,793.40 ns (91.15%) |
| transfer/pacing-true/same-seed/simulated-time/run | 📈 view plot 🚷 view threshold | 25,675,000,000.00 ns(+0.23%)Baseline: 25,616,866,359.45 ns | 25,712,876,773.41 ns (99.85%) |
| transfer/pacing-true/same-seed/wallclock-time/run | 📈 view plot 🚷 view threshold | 26,132,000.00 ns(-4.30%)Baseline: 27,305,635.94 ns | 28,745,144.00 ns (90.91%) |
| transfer/pacing-true/varying-seeds/simulated-time/run | 📈 view plot 🚷 view threshold | 24,984,000,000.00 ns(-0.04%)Baseline: 24,994,064,516.13 ns | 25,043,916,147.64 ns (99.76%) |
| transfer/pacing-true/varying-seeds/wallclock-time/run | 📈 view plot 🚷 view threshold | 25,404,000.00 ns(-4.48%)Baseline: 26,595,778.80 ns | 28,182,342.58 ns (90.14%) |
larseggert
changed the title
Collaborator
Author
|
This PR is now only adding the helper script. I'll do smaller, per-crate update PRs using this script afterwards. |
larseggert
changed the title
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to d4d877a. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Contributor
Client/server transfer resultsPerformance differences relative to 2c28baa. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Contributor
|
| Branch | chore-bump-deps |
| Testbed | On-prem |
🚨 2 Alerts
| Iteration | Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|---|
| 0 | google vs. neqo (cubic, paced) | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 281.98 ms(+1.42%)Baseline: 278.02 ms | 281.80 ms (100.06%) |
| 2 | neqo vs. google (cubic, paced) | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 777.06 ms(+2.46%)Baseline: 758.39 ms | 769.77 ms (100.95%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| google vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 281.98 ms(+1.42%)Baseline: 278.02 ms | 281.80 ms (100.06%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| msquic vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 193.99 ms(-1.77%)Baseline: 197.48 ms | 234.57 ms (82.70%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. google (cubic, paced) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 777.06 ms(+2.46%)Baseline: 758.39 ms | 769.77 ms (100.95%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. msquic (cubic, paced) | 📈 view plot 🚷 view threshold | 158.38 ms(+0.35%)Baseline: 157.83 ms | 160.80 ms (98.50%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (cubic) | 📈 view plot 🚷 view threshold | 95.88 ms(+5.19%)Baseline: 91.15 ms | 96.20 ms (99.67%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 95.86 ms(+3.58%)Baseline: 92.55 ms | 97.59 ms (98.23%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (reno) | 📈 view plot 🚷 view threshold | 94.00 ms(+3.05%)Baseline: 91.22 ms | 96.28 ms (97.63%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (reno, paced) | 📈 view plot 🚷 view threshold | 94.28 ms(+1.97%)Baseline: 92.46 ms | 97.35 ms (96.84%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. quiche (cubic, paced) | 📈 view plot 🚷 view threshold | 193.44 ms(-0.13%)Baseline: 193.69 ms | 197.06 ms (98.16%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. s2n (cubic, paced) | 📈 view plot 🚷 view threshold | 221.82 ms(+0.34%)Baseline: 221.07 ms | 224.03 ms (99.01%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| quiche vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 152.24 ms(-0.51%)Baseline: 153.03 ms | 158.23 ms (96.21%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| s2n vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 171.37 ms(-1.53%)Baseline: 174.02 ms | 178.12 ms (96.21%) |
Contributor
Benchmark resultsPerformance differences relative to 2c28baa. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [202.11 ms 202.53 ms 202.96 ms]
thrpt: [492.71 MiB/s 493.76 MiB/s 494.79 MiB/s]
change:
time: [−0.3917% −0.0410% +0.2782%] (p = 0.82 > 0.05)
thrpt: [−0.2774% +0.0411% +0.3932%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: Change within noise threshold. time: [285.53 ms 287.29 ms 289.10 ms]
thrpt: [34.591 Kelem/s 34.808 Kelem/s 35.023 Kelem/s]
change:
time: [−1.7676% −0.9190% −0.0377%] (p = 0.04 < 0.05)
thrpt: [+0.0378% +0.9276% +1.7994%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [38.778 ms 38.962 ms 39.166 ms]
thrpt: [25.533 B/s 25.666 B/s 25.788 B/s]
change:
time: [−1.0050% −0.2838% +0.5168%] (p = 0.46 > 0.05)
thrpt: [−0.5142% +0.2846% +1.0152%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [208.84 ms 209.14 ms 209.49 ms]
thrpt: [477.34 MiB/s 478.14 MiB/s 478.83 MiB/s]
change:
time: [−0.5077% −0.2733% −0.0260%] (p = 0.03 < 0.05)
thrpt: [+0.0260% +0.2740% +0.5103%]
decode 4096 bytes, mask ff: No change in performance detected. time: [10.611 µs 10.645 µs 10.685 µs]
change: [−0.1810% +0.1696% +0.6169%] (p = 0.41 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0209 ms 3.0292 ms 3.0389 ms]
change: [−0.8286% −0.2447% +0.3044%] (p = 0.42 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.372 µs 19.438 µs 19.513 µs]
change: [−0.8444% −0.0935% +0.5179%] (p = 0.81 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0371 ms 5.0487 ms 5.0618 ms]
change: [−0.8246% −0.2670% +0.2164%] (p = 0.34 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5183 µs 5.5285 µs 5.5423 µs]
change: [−0.8312% −0.1839% +0.4768%] (p = 0.59 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5870 ms 1.5991 ms 1.6178 ms]
change: [−0.7733% +0.1928% +1.5261%] (p = 0.78 > 0.05)
1-streams/each-1000-bytes/wallclock-time: 💔 Performance has regressed. time: [590.14 µs 592.43 µs 595.00 µs]
change: [+1.0000% +1.5158% +2.0470%] (p = 0.00 < 0.05)
1000-streams/each-1-bytes/wallclock-time: No change in performance detected. time: [13.628 ms 13.647 ms 13.666 ms]
change: [−0.1736% +0.0760% +0.3266%] (p = 0.55 > 0.05)
1000-streams/each-1-bytes/simulated-time: No change in performance detected. time: [15.028 s 15.043 s 15.057 s]
thrpt: [66.413 B/s 66.478 B/s 66.541 B/s]
change:
time: [−0.2016% −0.0567% +0.0814%] (p = 0.42 > 0.05)
thrpt: [−0.0813% +0.0567% +0.2020%]
1000-streams/each-1000-bytes/wallclock-time: No change in performance detected. time: [47.508 ms 47.688 ms 47.871 ms]
change: [−0.7873% −0.2914% +0.2239%] (p = 0.27 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [89.061 ns 89.361 ns 89.661 ns]
change: [−1.1146% −0.4497% +0.4416%] (p = 0.29 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [105.93 ns 106.28 ns 106.65 ns]
change: [−1.3432% −0.9897% −0.6210%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [105.69 ns 106.24 ns 106.84 ns]
change: [−1.6523% −0.9856% −0.3941%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [91.458 ns 91.612 ns 91.786 ns]
change: [−1.3279% −0.7734% −0.2064%] (p = 0.00 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [109.13 ms 109.31 ms 109.60 ms]
change: [−1.0445% −0.7099% −0.3739%] (p = 0.00 < 0.05)
sent::Packets::take_ranges: :green_heart: Performance has improved. time: [4.4405 µs 4.5318 µs 4.6165 µs]
change: [−8.1347% −5.0338% −1.9333%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds/wallclock-time/run: Change within noise threshold. time: [24.865 ms 24.903 ms 24.942 ms]
change: [−0.9646% −0.7525% −0.5379%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds/simulated-time/run: No change in performance detected. time: [25.150 s 25.184 s 25.218 s]
thrpt: [162.42 KiB/s 162.65 KiB/s 162.86 KiB/s]
change:
time: [−0.1853% +0.0068% +0.1943%] (p = 0.95 > 0.05)
thrpt: [−0.1939% −0.0068% +0.1856%]
transfer/pacing-true/varying-seeds/wallclock-time/run: Change within noise threshold. time: [25.264 ms 25.329 ms 25.397 ms]
change: [−1.2663% −0.9189% −0.6069%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds/simulated-time/run: No change in performance detected. time: [24.946 s 24.981 s 25.016 s]
thrpt: [163.74 KiB/s 163.97 KiB/s 164.19 KiB/s]
change:
time: [−0.2021% +0.0158% +0.2228%] (p = 0.89 > 0.05)
thrpt: [−0.2223% −0.0158% +0.2025%]
transfer/pacing-false/same-seed/wallclock-time/run: Change within noise threshold. time: [24.612 ms 24.639 ms 24.667 ms]
change: [−1.7562% −1.5700% −1.4125%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed/simulated-time/run: No change in performance detected. time: [25.525 s 25.525 s 25.525 s]
thrpt: [160.47 KiB/s 160.47 KiB/s 160.47 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000%]
transfer/pacing-true/same-seed/wallclock-time/run: Change within noise threshold. time: [26.495 ms 26.525 ms 26.564 ms]
change: [−0.5933% −0.4352% −0.2604%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed/simulated-time/run: No change in performance detected. time: [25.252 s 25.252 s 25.252 s]
thrpt: [162.21 KiB/s 162.21 KiB/s 162.21 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000%]
Download data for |
Collaborator
Author
|
Just a development helper script; merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper script to help with updating deps to with Gecko has.