chore: Fix claude#3042
Merged
Merged
Conversation
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates two duplicate Claude workflow files by removing the redundant claude-code-review.yml file and updating the original claude.yml file to use the consolidated configuration.
- Removed duplicate workflow file
.github/workflows/claude-code-review.yml - Updated
.github/workflows/claude.ymlto consolidate functionality from both workflows - Changed workflow trigger from comment-based activation to automatic PR events
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/claude.yml |
Updated workflow name, triggers, and configuration to consolidate Claude functionality |
.github/workflows/claude-code-review.yml |
Removed duplicate workflow file entirely |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
==========================================
- Coverage 93.42% 93.36% -0.06%
==========================================
Files 124 124
Lines 36045 36045
Branches 36045 36045
==========================================
- Hits 33674 33654 -20
- Misses 1525 1547 +22
+ Partials 846 844 -2
|
larseggert
force-pushed
the
chore-claude-cleanup
branch
from
4bf3a06 to
345e7cb
Compare
Contributor
|
Bencher Report| Branch | chore-claude-cleanup |
| Testbed | On-prem |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 39.99 ms(+38.42%)Baseline: 28.89 ms | 34.14 ms (117.14%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| 1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client | 📈 view plot 🚷 view threshold | 205,620,000.00 ns(-0.75%)Baseline: 207,180,040.32 ns | 217,750,554.11 ns (94.43%) |
| 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client | 📈 view plot 🚷 view threshold | 203,050,000.00 ns(+0.92%)Baseline: 201,208,911.29 ns | 212,700,375.64 ns (95.46%) |
| 1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 39,994,000.00 ns(+38.42%)Baseline: 28,892,504.03 ns | 34,142,856.71 ns (117.14%) |
| 1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client | 📈 view plot 🚷 view threshold | 292,110,000.00 ns(-0.11%)Baseline: 292,419,354.84 ns | 305,715,748.43 ns (95.55%) |
| 1-streams/each-1000-bytes/simulated-time | 📈 view plot 🚷 view threshold | 119,320,000.00 ns(+0.67%)Baseline: 118,526,935.48 ns | 120,838,482.46 ns (98.74%) |
| 1-streams/each-1000-bytes/wallclock-time | 📈 view plot 🚷 view threshold | 589,450.00 ns(-0.95%)Baseline: 595,128.91 ns | 619,495.30 ns (95.15%) |
| 1000-streams/each-1-bytes/simulated-time | 📈 view plot 🚷 view threshold | 14,998,000,000.00 ns(+0.03%)Baseline: 14,992,846,774.19 ns | 15,010,844,877.48 ns (99.91%) |
| 1000-streams/each-1-bytes/wallclock-time | 📈 view plot 🚷 view threshold | 13,682,000.00 ns(-2.80%)Baseline: 14,075,629.03 ns | 14,922,818.03 ns (91.69%) |
| 1000-streams/each-1000-bytes/simulated-time | 📈 view plot 🚷 view threshold | 19,050,000,000.00 ns(+0.53%)Baseline: 18,949,112,903.23 ns | 19,225,870,627.95 ns (99.09%) |
| 1000-streams/each-1000-bytes/wallclock-time | 📈 view plot 🚷 view threshold | 48,587,000.00 ns(-5.21%)Baseline: 51,256,314.52 ns | 57,949,002.21 ns (83.84%) |
| RxStreamOrderer::inbound_frame() | 📈 view plot 🚷 view threshold | 108,990,000.00 ns(-0.61%)Baseline: 109,661,491.94 ns | 111,737,716.94 ns (97.54%) |
| coalesce_acked_from_zero 1+1 entries | 📈 view plot 🚷 view threshold | 88.86 ns(+0.29%)Baseline: 88.61 ns | 89.25 ns (99.56%) |
| coalesce_acked_from_zero 10+1 entries | 📈 view plot 🚷 view threshold | 105.91 ns(-0.14%)Baseline: 106.06 ns | 107.07 ns (98.91%) |
| coalesce_acked_from_zero 1000+1 entries | 📈 view plot 🚷 view threshold | 89.74 ns(-0.07%)Baseline: 89.80 ns | 94.10 ns (95.37%) |
| coalesce_acked_from_zero 3+1 entries | 📈 view plot 🚷 view threshold | 106.36 ns(-0.18%)Baseline: 106.56 ns | 107.55 ns (98.90%) |
| decode 1048576 bytes, mask 3f | 📈 view plot 🚷 view threshold | 1,772,200.00 ns(+9.33%)Baseline: 1,620,935.08 ns | 1,773,296.46 ns (99.94%) |
| decode 1048576 bytes, mask 7f | 📈 view plot 🚷 view threshold | 5,096,200.00 ns(+0.63%)Baseline: 5,064,388.71 ns | 5,105,618.96 ns (99.82%) |
| decode 1048576 bytes, mask ff | 📈 view plot 🚷 view threshold | 3,014,900.00 ns(-0.48%)Baseline: 3,029,383.06 ns | 3,046,941.57 ns (98.95%) |
| decode 4096 bytes, mask 3f | 📈 view plot 🚷 view threshold | 5,561.80 ns(-29.18%)Baseline: 7,853.49 ns | 10,216.37 ns (54.44%) |
| decode 4096 bytes, mask 7f | 📈 view plot 🚷 view threshold | 19,372.00 ns(-2.70%)Baseline: 19,909.84 ns | 20,434.44 ns (94.80%) |
| decode 4096 bytes, mask ff | 📈 view plot 🚷 view threshold | 10,652.00 ns(-7.73%)Baseline: 11,544.61 ns | 12,494.25 ns (85.26%) |
| sent::Packets::take_ranges | 📈 view plot 🚷 view threshold | 4,655.70 ns(-1.82%)Baseline: 4,742.07 ns | 4,977.18 ns (93.54%) |
| transfer/pacing-false/same-seed/simulated-time/run | 📈 view plot 🚷 view threshold | 25,710,000,000.00 ns(+1.30%)Baseline: 25,381,097,560.98 ns | 26,023,886,538.47 ns (98.79%) |
| transfer/pacing-false/same-seed/wallclock-time/run | 📈 view plot 🚷 view threshold | 25,459,000.00 ns(-1.81%)Baseline: 25,928,711.38 ns | 26,993,329.40 ns (94.32%) |
| transfer/pacing-false/varying-seeds/simulated-time/run | 📈 view plot 🚷 view threshold | 25,148,000,000.00 ns(-0.09%)Baseline: 25,171,239,837.40 ns | 25,219,247,519.81 ns (99.72%) |
| transfer/pacing-false/varying-seeds/wallclock-time/run | 📈 view plot 🚷 view threshold | 25,226,000.00 ns(-3.10%)Baseline: 26,032,841.46 ns | 27,507,254.75 ns (91.71%) |
| transfer/pacing-true/same-seed/simulated-time/run | 📈 view plot 🚷 view threshold | 25,675,000,000.00 ns(+0.20%)Baseline: 25,623,719,512.20 ns | 25,723,939,299.01 ns (99.81%) |
| transfer/pacing-true/same-seed/wallclock-time/run | 📈 view plot 🚷 view threshold | 26,468,000.00 ns(-2.94%)Baseline: 27,269,890.24 ns | 28,660,207.05 ns (92.35%) |
| transfer/pacing-true/varying-seeds/simulated-time/run | 📈 view plot 🚷 view threshold | 25,006,000,000.00 ns(+0.05%)Baseline: 24,993,825,203.25 ns | 25,043,434,180.90 ns (99.85%) |
| transfer/pacing-true/varying-seeds/wallclock-time/run | 📈 view plot 🚷 view threshold | 25,670,000.00 ns(-3.28%)Baseline: 26,541,760.16 ns | 28,092,228.39 ns (91.38%) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
larseggert
force-pushed
the
chore-claude-cleanup
branch
from
6d3885e to
e5180be
Compare
Contributor
|
| Branch | chore-claude-cleanup |
| Testbed | On-prem |
🚨 2 Alerts
| Iteration | Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|---|
| 4 | neqo vs. neqo (cubic) | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 95.25 ms(+5.22%)Baseline: 90.53 ms | 94.60 ms (100.69%) |
| 6 | neqo vs. neqo (reno) | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 94.78 ms(+4.68%)Baseline: 90.54 ms | 94.34 ms (100.46%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| google vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 278.39 ms(+0.25%)Baseline: 277.70 ms | 280.37 ms (99.29%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| msquic vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 188.05 ms(-4.43%)Baseline: 196.75 ms | 233.69 ms (80.47%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. google (cubic, paced) | 📈 view plot 🚷 view threshold | 753.51 ms(-0.52%)Baseline: 757.44 ms | 764.40 ms (98.58%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. msquic (cubic, paced) | 📈 view plot 🚷 view threshold | 159.54 ms(+1.17%)Baseline: 157.69 ms | 160.72 ms (99.27%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (cubic) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 95.25 ms(+5.22%)Baseline: 90.53 ms | 94.60 ms (100.69%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 94.86 ms(+3.21%)Baseline: 91.90 ms | 95.78 ms (99.04%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (reno) | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 94.78 ms(+4.68%)Baseline: 90.54 ms | 94.34 ms (100.46%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. neqo (reno, paced) | 📈 view plot 🚷 view threshold | 95.70 ms(+4.20%)Baseline: 91.84 ms | 95.73 ms (99.97%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. quiche (cubic, paced) | 📈 view plot 🚷 view threshold | 194.21 ms(+0.26%)Baseline: 193.70 ms | 197.10 ms (98.54%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| neqo vs. s2n (cubic, paced) | 📈 view plot 🚷 view threshold | 220.87 ms(+0.00%)Baseline: 220.87 ms | 223.66 ms (98.75%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| quiche vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 152.20 ms(-0.54%)Baseline: 153.02 ms | 158.61 ms (95.96%) |
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| s2n vs. neqo (cubic, paced) | 📈 view plot 🚷 view threshold | 176.19 ms(+1.14%)Baseline: 174.20 ms | 178.33 ms (98.80%) |
mxinden
approved these changes
Oct 24, 2025
Remove dup'ed workflow and don't pin the action.
larseggert
force-pushed
the
chore-claude-cleanup
branch
from
e5180be to
2a94dc2
Compare
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Contributor
Client/server transfer resultsPerformance differences relative to fb47282. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
Contributor
Benchmark resultsPerformance differences relative to fb47282. 1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [202.54 ms 203.05 ms 203.78 ms]
thrpt: [490.74 MiB/s 492.49 MiB/s 493.73 MiB/s]
change:
time: [+0.0403% +0.3706% +0.7883%] (p = 0.04 < 0.05)
thrpt: [−0.7821% −0.3693% −0.0403%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [290.42 ms 292.11 ms 293.81 ms]
thrpt: [34.035 Kelem/s 34.233 Kelem/s 34.433 Kelem/s]
change:
time: [−0.6342% +0.2475% +1.0790%] (p = 0.57 > 0.05)
thrpt: [−1.0675% −0.2469% +0.6383%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold. time: [39.747 ms 39.994 ms 40.256 ms]
thrpt: [24.841 B/s 25.004 B/s 25.159 B/s]
change:
time: [+0.3901% +1.1639% +1.9923%] (p = 0.00 < 0.05)
thrpt: [−1.9534% −1.1505% −0.3886%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [205.30 ms 205.62 ms 205.97 ms]
thrpt: [485.51 MiB/s 486.33 MiB/s 487.08 MiB/s]
change:
time: [−0.6212% −0.3796% −0.1473%] (p = 0.00 < 0.05)
thrpt: [+0.1476% +0.3810% +0.6250%]
decode 4096 bytes, mask ff: No change in performance detected. time: [10.614 µs 10.652 µs 10.697 µs]
change: [−0.4595% −0.0094% +0.4603%] (p = 0.97 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0056 ms 3.0149 ms 3.0258 ms]
change: [−0.5262% −0.0400% +0.4537%] (p = 0.89 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.330 µs 19.372 µs 19.423 µs]
change: [−0.5972% +0.1448% +1.0215%] (p = 0.76 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.0849 ms 5.0962 ms 5.1092 ms]
change: [−0.4167% −0.0569% +0.3158%] (p = 0.75 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5312 µs 5.5618 µs 5.5982 µs]
change: [−0.7250% +0.1452% +1.0580%] (p = 0.76 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7605 ms 1.7722 ms 1.7900 ms]
change: [+0.0636% +0.7314% +1.8998%] (p = 0.10 > 0.05)
1-streams/each-1000-bytes/wallclock-time: Change within noise threshold. time: [587.44 µs 589.45 µs 591.77 µs]
change: [+0.1176% +0.6906% +1.2886%] (p = 0.02 < 0.05)
1000-streams/each-1-bytes/wallclock-time: No change in performance detected. time: [13.661 ms 13.682 ms 13.704 ms]
change: [−0.2797% −0.0518% +0.1703%] (p = 0.66 > 0.05)
1000-streams/each-1000-bytes/wallclock-time: No change in performance detected. time: [48.406 ms 48.587 ms 48.770 ms]
change: [−0.4605% +0.2702% +0.8942%] (p = 0.45 > 0.05)
1000-streams/each-1000-bytes/simulated-time: No change in performance detected. time: [18.889 s 19.050 s 19.212 s]
thrpt: [50.832 KiB/s 51.263 KiB/s 51.701 KiB/s]
change:
time: [−1.7348% −0.3843% +1.0149%] (p = 0.59 > 0.05)
thrpt: [−1.0047% +0.3858% +1.7655%]
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [88.545 ns 88.860 ns 89.176 ns]
change: [−0.7812% −0.0142% +0.5630%] (p = 0.97 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [106.08 ns 106.36 ns 106.67 ns]
change: [+0.2666% +0.5664% +0.8569%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [105.57 ns 105.91 ns 106.36 ns]
change: [−1.1760% +0.5671% +2.1004%] (p = 0.57 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [89.592 ns 89.736 ns 89.892 ns]
change: [−0.2108% +0.8667% +1.8630%] (p = 0.10 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [108.85 ms 108.99 ms 109.17 ms]
change: [−1.0779% −0.7562% −0.4820%] (p = 0.00 < 0.05)
sent::Packets::take_ranges: No change in performance detected. time: [4.5374 µs 4.6557 µs 4.7631 µs]
change: [−2.6985% +1.4050% +6.0835%] (p = 0.57 > 0.05)
transfer/pacing-false/varying-seeds/wallclock-time/run: Change within noise threshold. time: [25.186 ms 25.226 ms 25.268 ms]
change: [−2.4495% −2.2268% −2.0012%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds/simulated-time/run: No change in performance detected. time: [25.115 s 25.148 s 25.180 s]
thrpt: [162.67 KiB/s 162.88 KiB/s 163.09 KiB/s]
change:
time: [−0.3749% −0.1811% +0.0079%] (p = 0.06 > 0.05)
thrpt: [−0.0079% +0.1814% +0.3763%]
transfer/pacing-true/varying-seeds/wallclock-time/run: Change within noise threshold. time: [25.607 ms 25.670 ms 25.735 ms]
change: [−1.5252% −1.1852% −0.8617%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds/simulated-time/run: No change in performance detected. time: [24.970 s 25.006 s 25.044 s]
thrpt: [163.55 KiB/s 163.80 KiB/s 164.04 KiB/s]
change:
time: [−0.0555% +0.1570% +0.3733%] (p = 0.16 > 0.05)
thrpt: [−0.3719% −0.1567% +0.0555%]
transfer/pacing-false/same-seed/wallclock-time/run: No change in performance detected. time: [25.431 ms 25.459 ms 25.496 ms]
change: [−0.1033% +0.0525% +0.2338%] (p = 0.55 > 0.05)
transfer/pacing-false/same-seed/simulated-time/run: No change in performance detected. time: [25.710 s 25.710 s 25.710 s]
thrpt: [159.31 KiB/s 159.31 KiB/s 159.31 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000%]
transfer/pacing-true/same-seed/wallclock-time/run: Change within noise threshold. time: [26.449 ms 26.468 ms 26.489 ms]
change: [−2.0078% −1.8268% −1.6857%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed/simulated-time/run: No change in performance detected. time: [25.675 s 25.675 s 25.675 s]
thrpt: [159.53 KiB/s 159.53 KiB/s 159.53 KiB/s]
change:
time: [+0.0000% +0.0000% +0.0000%] (p = NaN > 0.05)
thrpt: [+0.0000% +0.0000% +0.0000%]
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dup'ed workflow and don't pin the action.