Extend nss-rs with the Hybrid KEMs (XWING)#18
Open
beurdouche wants to merge 4 commits into
Open
Conversation
beurdouche
force-pushed
the
beurdouche-kem-hybrid
branch
from
bfb600c to
48915a8
Compare
Member
Author
|
The SHA3 commit can be reviewed before the rest in #17 |
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
I have a lot of questions about this code, but let's start with the big one: why is the combiner implemented in the binding wrapper, rather than in NSS proper?
| impl MlKemParameterSet { | ||
| /// Returns the PKCS#11 parameter set constant. | ||
| #[must_use] | ||
| pub const fn to_ck_param(self) -> u64 { |
Member
There was a problem hiding this comment.
I don't like the use of u32 or u64 for types that NSS defines as unsigned int or similar. I would prefer to use types generated by bindgen, even if that makes this code less pleasant to work with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP