Add support for PKCS#11 token key management#29
Merged
Conversation
beurdouche
requested review from
Not-Nik
and removed request for
larseggert and
martinthomson
Not-Nik
requested changes
Mar 26, 2026
Collaborator
Not-Nik
left a comment
Not-Nik
left a comment
There was a problem hiding this comment.
Please fix these two warnings the CI brought up
| if ptr.is_null() { | ||
| None | ||
| } else { | ||
| unsafe { SymKey::from_ptr(ptr).ok() } |
Collaborator
There was a problem hiding this comment.
This unsafe is not needed
Member
Author
There was a problem hiding this comment.
Fixed. Interestingly, my local clippy didn't complain...
Collaborator
There was a problem hiding this comment.
This qualification (std::os::raw::) is no longer needed since you imported c_int
beurdouche
force-pushed
the
2026-03-26-pk11-mgt
branch
2 times, most recently
from
8f75686 to
fb407c4
Compare
beurdouche
force-pushed
the
2026-03-26-pk11-mgt
branch
from
fb407c4 to
f0eabc5
Compare
Frosne
approved these changes
Mar 27, 2026
Member
Author
|
Thanks Anna ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.