Skip to content

Revert "chore: Rename crate to nss"#38

Merged
Not-Nik merged 3 commits into
mainfrom
revert-35-rename-nss
Apr 21, 2026
Merged

Revert "chore: Rename crate to nss"#38
Not-Nik merged 3 commits into
mainfrom
revert-35-rename-nss

Conversation

@Not-Nik
Copy link
Copy Markdown
Collaborator

@Not-Nik Not-Nik commented Apr 17, 2026

Reverts #35. See #27. The version can stay the same, since we will need to go back to versions > 0.7.1 when we go back to "nss" (see original PR)

@Not-Nik Not-Nik marked this pull request as ready for review April 17, 2026 10:05
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean revert of #35. Verified the diff is an exact inverse of the original rename (all 13 files, all nssnss-rs/nss_rs references), with the intentional exception of keeping the version at 0.8.0 rather than reverting to 0.3.0 — which makes sense given the crates.io versioning constraint noted in the PR description.

The tests/init.rs module rename (nss_initnss) is correct: the name conflict that motivated renaming it in #35 no longer exists now that the crate is back to nss_rs.

CI is green across all completed checks (sanitizers, format, deny, dependency-review, multiple platform/toolchain combos); a few clippy/Windows jobs are still in progress.

One minor pre-existing issue flagged inline (src/sig.rs stale import) — non-blocking since the file is dead code.

Comment thread src/sig.rs
Comment thread build.rs
Comment thread build.rs
Comment thread src/err.rs
@Not-Nik Not-Nik force-pushed the revert-35-rename-nss branch from 4a7d0df to 94a1c6e Compare April 21, 2026 09:38
@Not-Nik Not-Nik merged commit 7cc1c33 into main Apr 21, 2026
44 checks passed
@larseggert larseggert deleted the revert-35-rename-nss branch May 1, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants