Skip to content

chore: Merge CI changes from neqo#47

Merged
Not-Nik merged 2 commits into
mozilla:mainfrom
Not-Nik:update-ci-260506
May 7, 2026
Merged

chore: Merge CI changes from neqo#47
Not-Nik merged 2 commits into
mozilla:mainfrom
Not-Nik:update-ci-260506

Conversation

@Not-Nik
Copy link
Copy Markdown
Collaborator

@Not-Nik Not-Nik commented May 6, 2026

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@71eeddf). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage        ?   68.89%           
=======================================
  Files           ?       26           
  Lines           ?     3244           
  Branches        ?     3244           
=======================================
  Hits            ?     2235           
  Misses          ?      806           
  Partials        ?      203           
Flag Coverage Δ
freebsd 68.89% <ø> (?)
linux 68.89% <ø> (?)
macos 68.89% <ø> (?)
windows 68.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR ports CI improvements from neqo: bumps all vmactions/* VM actions to current versions, adds copyback: true for artifact retrieval, installs bindgen tooling on all BSD platforms, and wires up a new bindgen-args input to generate + diff-check bindings inside the VM (with artifact upload for downstream consumption). It also adds a push trigger to the actionlint workflow.

The bindgen infrastructure is well-structured — the early-exit-on-drift pattern avoids wasting CI time compiling against stale bindings. A couple of minor items flagged inline (NetBSD formatting, artifact upload condition).

Comment thread .github/actions/check-vm/action.yml
Comment thread .github/actions/check-vm/action.yml
Comment thread .github/actions/check-vm/action.yml
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean infrastructure PR porting CI improvements from neqo. The vmactions bumps and copyback: true additions are straightforward. The bindgen infrastructure (input, package installs, generate-diff-upload pipeline) is well-structured.

Key observation: the bindgen-args codepath is currently inert — no workflow passes the input — so none of the new bindgen logic will execute until a follow-up wires it up. This also means it can't be validated by CI from this PR alone.

The prior bot review's feedback on NetBSD ;; formatting and always()!cancelled() is still unaddressed and worth fixing before merge.

Comment thread .github/actions/check-vm/action.yml
Comment thread .github/actions/check-vm/action.yml
@Not-Nik Not-Nik merged commit 0ea3df7 into mozilla:main May 7, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants