Skip to content

Update Search to use search and hash #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kala-moz merged 12 commits into from
May 15, 2025
Merged

Update Search to use search and hash #865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6473861
update search input to use search and hash
Netacci Feb 5, 2025
e97dc33
resolve merge conflict
Netacci Feb 26, 2025
bedd8b2
add test for new search path
Netacci Feb 5, 2025
c97b49b
update snapshot nd resolve merge conflict
Netacci Feb 26, 2025
7d9c716
update snapshots using npm 22
Netacci Mar 11, 2025
327d442
prototype url
Netacci Mar 27, 2025
527b7ae
add prototype url
Netacci Mar 27, 2025
0dffc4d
update treeherder url
Netacci Apr 22, 2025
9504782
resolve merge conflict
Netacci Apr 22, 2025
a2743a9
update input placeholder text
Netacci Apr 23, 2025
40a66a9
move fulltextsearch feature behind useFulltextSearch flag
Netacci May 15, 2025
edd59bc
update test coverage for revision numbers when useFulltextsearch is b…
Netacci May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,10 @@ exports[`Results Table Should match snapshot 1`] = `
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -523,10 +523,10 @@ exports[`Results Table Should match snapshot 1`] = `
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down
12 changes: 7 additions & 5 deletions src/__tests__/Search/SearchView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ describe('Search Container', () => {
name: baseTitle,
});

const baseInput = screen.getByPlaceholderText(
'Search base by ID number or author email',
);
const baseInput = screen.getAllByPlaceholderText(
'Search by revision ID or author email',
)[0];
const repoDropdown = screen.getByRole('button', { name: 'Base' });

expect(compTitle).toBeInTheDocument();
Expand All @@ -160,13 +160,15 @@ describe('Base and OverTime Search', () => {

// Search input appears
expect(
screen.getByPlaceholderText(/Search base by ID number or author email/i),
screen.getAllByPlaceholderText(
/Search by revision ID or author email/i,
)[0],
).toBeInTheDocument();

await expandOverTimeComponent();
expect(
screen.getAllByPlaceholderText(
/Search revision by ID number or author email/i,
/Search by revision ID or author email/i,
)[1],
).toBeInTheDocument();

Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/Search/SelectedRevision.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('SelectedRevision', () => {
expect(baseDropdown).toHaveTextContent('try');

const firstSearchInput = screen.getAllByPlaceholderText(
'Search base by ID number or author email',
'Search by revision ID or author email',
)[0];
await user.click(firstSearchInput);
await user.click(
Expand Down
16 changes: 8 additions & 8 deletions src/__tests__/Search/__snapshots__/CompareOverTime.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,10 @@ exports[`Compare Over Time renders correctly in Search View: Initial state for t
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -1174,10 +1174,10 @@ exports[`Compare Over Time should have an edit mode in Results View: After click
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -1970,10 +1970,10 @@ exports[`Compare Over Time should remove the checked revision once X button is c
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -2856,10 +2856,10 @@ exports[`Compare Over Time should update base repo, revisions and time-range aft
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down
60 changes: 30 additions & 30 deletions src/__tests__/Search/__snapshots__/CompareWithBase.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ exports[`Compare With Base renders correctly when there are no results: Initial
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -447,10 +447,10 @@ exports[`Compare With Base renders correctly when there are no results: Initial
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -953,10 +953,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -1263,10 +1263,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -1457,10 +1457,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -1767,10 +1767,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -2148,10 +2148,10 @@ exports[`Compare With Base should have an edit mode in Results View: Initial sta
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -2458,10 +2458,10 @@ exports[`Compare With Base should have an edit mode in Results View: Initial sta
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -2826,10 +2826,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -2970,10 +2970,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -3376,10 +3376,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -3686,10 +3686,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -4000,10 +4000,10 @@ exports[`Compare With Base should remove the checked revision once X button is c
</div>
<input
aria-invalid="false"
aria-label="Search base by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
id="search-base-input"
placeholder="Search base by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -4144,10 +4144,10 @@ exports[`Compare With Base should remove the checked revision once X button is c
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down Expand Up @@ -4566,10 +4566,10 @@ exports[`Compare With Base should remove the checked revision once X button is c
</div>
<input
aria-invalid="false"
aria-label="Search revision by ID number or author email"
aria-label="Search by revision ID or author email"
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
id="search-new-input"
placeholder="Search revision by ID number or author email"
placeholder="Search by revision ID or author email"
type="text"
value=""
/>
Expand Down
Loading