Change default theme to system #3549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
reviewed
Feb 3, 2025
Collaborator
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
Nice work!
I noticed two issues when using the light system theme:
- The Sign In button uses the light text color, which is not readable on the light background.
- When I click the Sign In button, the login page appears dark. See https://github.com/mozilla/pontoon/tree/main/pontoon/base/templates/django.
mathjazz
reviewed
Feb 13, 2025
Collaborator
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
Nice work!
The only remaining issue is that if a system theme is set to light, users will experience FOUC when logged out.
We must still be defaulting to the dark theme somewhere, and need to make sure we honour prefers-color-scheme before the page renders.
Collaborator
|
Superseded by #3649. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3339
This PR changes the default theme for all users to match their system preferences, regardless of if they're an authenticated user.
To reproduce results: After running the server, open
localhost:8000in a new tab. Then, go into your computer's system settings and switch your preferred theme to the opposite of what you currently have selected. You should see Pontoon's theme also change at the same time you switch your preferred theme.