Add Entity and Search pages #3799

functionzz · 2025-10-07T15:54:35Z

Creates 2 pages, one which conducts entity translation search, the other displays the entity with all translations.
Inspired by the functionality of Tranvision.

codecov-commenter · 2025-10-07T16:00:39Z

Codecov Report

❌ Patch coverage is 34.86239% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.46%. Comparing base (22aa0af) to head (9568466).

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

functionzz · 2025-10-07T16:59:44Z

pontoon/search/views.py

+from pontoon.base.models.entity import Entity
+
+
+BASE_URL = "http://localhost:8000/api/v2"


Is there anywhere we have a macro that includes the BASE_URL, irrespective of production or local environment?

We have SITE_URL, but I'm not sure you mean that. Irrespective or respective?

If the DRF endpoint is part of the same Django project, you don’t need to make an actual HTTP request — you can just invoke the view logic directly, which should be faster and doesn’t require the network stack.

I might need to make this happen - for some endpoints like /new-search/?search=fi&locale=en-CA, the fetching is quite slow(around 5 seconds), which could signify a problem with the implementation, but will also be sped up with this.

This sounds more like a DB rather than a network latency issue.

pontoon/search/static/css/translations.css

mathjazz · 2025-10-07T19:49:20Z

pontoon/search/views.py

+from pontoon.base.models.entity import Entity
+
+
+BASE_URL = "http://localhost:8000/api/v2"


We have SITE_URL, but I'm not sure you mean that. Irrespective or respective?

mathjazz · 2025-10-07T19:51:07Z

pontoon/search/views.py

+from pontoon.base.models.entity import Entity
+
+
+BASE_URL = "http://localhost:8000/api/v2"


If the DRF endpoint is part of the same Django project, you don’t need to make an actual HTTP request — you can just invoke the view logic directly, which should be faster and doesn’t require the network stack.

functionzz · 2025-10-08T00:37:17Z

We have SITE_URL, but I'm not sure you mean that. Irrespective or respective?
Exactly what I mean, thank you.

If the DRF endpoint is part of the same Django project, you don’t need to make an actual HTTP request — you can just invoke the view logic directly, which should be faster and doesn’t require the network stack.

You are 100% right

pontoon/search/views.py

mathjazz · 2025-10-22T19:40:04Z

Remaining TODOs:
* [ ] clipboard
* [ ] replace url with /search instead of /new-search

The URL change sounds like a low hanging fruit, so I suggest just doing it.

Re clipboard: note that we already have it implemented in Machinery.

mathjazz · 2025-10-22T20:45:44Z

Core functionality is currently implemented

As per the Slack "spec" we're missing the source string metadata on the entity page, as well as the Link to translate view.

mathjazz · 2025-10-22T19:38:37Z

pontoon/search/views.py

+from pontoon.base.models.entity import Entity
+
+
+BASE_URL = "http://localhost:8000/api/v2"


This sounds more like a DB rather than a network latency issue.

pontoon/api/tests/test_views.py

pontoon/api/views.py

pontoon/search/static/css/translations.css

pontoon/search/static/js/search.js

pontoon/search/templates/search/widgets/entity_list.html

pontoon/teams/templates/teams/widgets/team_selector.html

mathjazz

Thanks for the update.

A general note: It's hard to follow the changes if not all comments are addressed. We either need to keep track of the exact list of things to do, or (preferable) address all review comments before requesting a new review.

We should:

Investigate why is the initial page load of the /search page rather slow
Require explicit true value for all boolean query parameters
Use semantic elements and class names in markup
Keep entity.key in /search and /entities unless it's just a reformated string (e.g. in PO files)
Add keyboard shortcut to trigger search with Enter
Add ability to copy search results to clipboard

pontoon/search/templates/search/widgets/entity_list.html

Updates translation search page with checkboxes, project/locale selectors with jQuery. Adds backend view, URL routing, and project selector macro to support searching by locale, project, and various options. Update settings pipeline.

…ling

…pagination

…alizer

functionzz changed the title ~~Add Entity and Search pages to Pontoon~~ Add Entity and Search pages Oct 7, 2025

functionzz commented Oct 7, 2025

View reviewed changes

mathjazz reviewed Oct 7, 2025

View reviewed changes

functionzz commented Oct 8, 2025

View reviewed changes

pontoon/search/views.py Outdated Show resolved Hide resolved

functionzz requested a review from mathjazz October 22, 2025 18:50

This comment was marked as outdated.

Sign in to view

functionzz marked this pull request as ready for review October 22, 2025 19:10

mathjazz reviewed Oct 22, 2025

View reviewed changes

functionzz requested a review from mathjazz October 24, 2025 15:34

mathjazz reviewed Oct 24, 2025

View reviewed changes

functionzz force-pushed the translations_to_all_locales_page branch 2 times, most recently from eea8361 to 297688f Compare November 10, 2025 17:06

functionzz requested a review from mathjazz November 17, 2025 22:28

mathjazz reviewed Nov 24, 2025

View reviewed changes

pontoon/search/templates/search/widgets/entity_list.html Outdated Show resolved Hide resolved

functionzz requested a review from mathjazz November 25, 2025 14:33

functionzz added 11 commits December 15, 2025 11:56

add individual entity page template + search django app

2f1b8fc

edit entity view to use internal drf views

42d1814

ran make format

f27da48

Add translation search feature with UI and backend

3b723b1

Updates translation search page with checkboxes, project/locale selectors with jQuery. Adds backend view, URL routing, and project selector macro to support searching by locale, project, and various options. Update settings pipeline.

undo unintended change

6923bff

save input based on url

81d16bb

added validation

c181801

slight change to validation

e290f40

infinite pagination, REST API query parameter changes

27ac54e

Update views.py

00a6fb0

Delete pontoon/search/static/css/entity.css

64806df

functionzz added 19 commits December 15, 2025 11:56

change entity data structure in serializer, clean up html for css sty…

edbdf2a

…ling

clean up entity - translation_list.html

1360f20

/search for entity translation search, small validation fix

7c3929f

Delete translations.css

a12fcd6

move project selector to projects app

9a7b173

remove id, useless html, add semantic classes

943fa47

small changes to translation search api endpoint

a06d623

remove 2 character limit

7f632b8

added source string metadata + translate module links to entity page

f0e23c2

reformed true/false values in translation search view, edited scroll …

5f3e61a

…pagination

change rest api flags to only use True and true

68b1c02

add semantic classes, edit entity api call

dda58d8

add clipboard

6d139e2

fix test

4d034f4

Make Search Page Efficient Again

2c4e373

prevent N+1

9f2f697

exclude gettext keys from entity list UI, add format to resource seri…

5b0b76e

…alizer

run make format

5c41e79

remove else block

9568466

functionzz force-pushed the translations_to_all_locales_page branch from 4c90308 to 9568466 Compare December 15, 2025 16:56

		from pontoon.base.models.entity import Entity


		BASE_URL = "http://localhost:8000/api/v2"

Add Entity and Search pages #3799

Are you sure you want to change the base?

Add Entity and Search pages #3799

Conversation

functionzz commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

functionzz commented Oct 8, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

mathjazz commented Oct 22, 2025

Uh oh!

mathjazz commented Oct 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathjazz left a comment • edited by functionzz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

functionzz commented Oct 7, 2025 •

edited

Loading

codecov-commenter commented Oct 7, 2025 •

edited

Loading

mathjazz left a comment •

edited by functionzz

Loading