Show obsolete entities as such #3851
Open
+61
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Should we keep allowing that, or prevent it completely as we'll do when #3148 is fixed? |
Member
Author
|
Occasionally I find value in being able to see Pontoon's representation of an obsolete entity and its translations, but we might indeed want to seek to prevent that from happening by default. But even if we do, something like the changes here would be a Good Idea in case any later change makes obsolete entities visible again, even if accidentally. |
Collaborator
|
@flodolo and I talked about this and we both think that we should just prevent obsolete entities from showing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible to end up looking at an obsolete entity in Pontoon when using its entity identifier directly as a
stringquery parameter. When this happens, we should highlight for the user that the string they're looking at is not in active use, and ensure that it's treated as readonly.Some cleanup of the previous/next entity hooks is included.