Use MF2 syntax for xcode & xliff strings #3855
Open
+291
−274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
Member
Author
|
Huh, looks like I managed to leave out the dependencies on mozilla/moz-l10n#116 from this PR, so that update can and should be handled separately. This is still blocking on #3848, though. |
Member
Author
|
This should be ready now for general XLIFF support. For XCode plurals, we'll need at least mozilla/moz-l10n#117, and possibly a bit more for XCode string catalog plurals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3848 and mozilla/moz-l10n#116; tests will fail until the latter is merged and a new moz.l10n version included here.The preview code is generalised here for use in all MF2-ish formats, not just Android. Otherwise the code changes follow the same shape as used for previous MF2 migrations.
Technically, this PR adds XCode plural support to Pontoon, but that has not been validated yet, and we'll want to add string catalog support before advertising the functionality.