Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
461f98b
Update Ace Editor version (#5041)
gabrieldutra Jul 14, 2020
6f9e79c
getredash/redash#5031 Counter is too large on Query View/Source pages…
kravets-levko Jul 14, 2020
d12691d
Databricks Schema Browser: Allow eventlet worker instead of RQ (#5045)
gabrieldutra Jul 15, 2020
cb97364
Dashboard URL does not show new name when dashboard name is updated (…
Jul 16, 2020
41a6913
Fix bundle-extensions script to work on recent importlib-resources. (…
jezdez Jul 16, 2020
48924de
Add TypeScript support (#5027)
simonschneider-db Jul 16, 2020
95c28c4
Eager load outdated queries (#5049)
Jul 16, 2020
6c349ea
Bump lodash from 4.17.15 to 4.17.19 in /viz-lib (#5051)
dependabot[bot] Jul 17, 2020
a1255b4
Fix wrong Y-axis range for stacked bar chart (#5029)
kravets-levko Jul 17, 2020
7f98d7b
Load extensions on db init (#5062)
Jul 23, 2020
fd76a2e
Add Column Type to Databricks schema browser (#5052)
gabrieldutra Jul 23, 2020
2dacd08
Add override mechanism for webpack config (#5057)
benamorbe Jul 27, 2020
7804dfd
loosen up some proptypes and backend casting to allow different prima…
Jul 27, 2020
f3a47a9
Move page size select to the Paginator component (#5064)
gabrieldutra Jul 27, 2020
93b4be6
Queries list: move "My Queries" above "Archived" (#5072)
kravets-levko Jul 28, 2020
24c9537
Introduce caching to the Databricks Schema Browser (#5038)
gabrieldutra Jul 30, 2020
3332b65
Make sure Policy is loaded for user session (#5081)
gabrieldutra Jul 31, 2020
d3b639a
Exposing setting for overriding template directory (#4324)
blarghmatey Aug 4, 2020
f56f4c4
fix: Compose version due to --build-arg (#5083)
koooge Aug 5, 2020
6c00f7c
Add: periodic job to remove ghost locks. (#5087)
arikfr Aug 5, 2020
eb603f6
Bar chart with second y axis overlaps data series (#4150)
kravets-levko Aug 5, 2020
5afd055
Add support for CSRF tokens (#5055)
Aug 9, 2020
83c6a6b
Make table visualization header fixed (#5103)
gaecoli Aug 17, 2020
378cc57
CSRF Exempts (#5108)
Aug 17, 2020
b326d36
Update Organization Settings (#5114)
gabrieldutra Aug 19, 2020
fc71acd
Make DataSourceListComponent a dynamic component (#5113)
gabrieldutra Aug 19, 2020
a596d65
Use Skeleton as ItemsList loading state (#5079)
gabrieldutra Aug 19, 2020
de052ff
Cypress touch-ups (#5109)
Aug 19, 2020
4c70b5c
Remove content width limit on all pages (#5091)
kravets-levko Aug 20, 2020
1bc6cd8
Keep widget loading when fetch request is replaced (#5118)
gabrieldutra Aug 20, 2020
ac652c2
Fix create link on data sources page (#5121)
gabrieldutra Aug 21, 2020
2cc3bd3
Add DynamicComponent to PermissionsControl flag (#5116)
gabrieldutra Aug 21, 2020
84d516b
Misc changes to codebase back ported from internal fork (#5129)
arikfr Aug 25, 2020
596e5be
Misc changes to codebase back ported from internal fork - part 2 (#5130)
arikfr Aug 25, 2020
a31196a
Upgrade Ant Design to v4 (#5068)
gabrieldutra Aug 25, 2020
c6ce159
In docker-entrypoint ensure tables exist
Apr 12, 2017
8e52936
Add migrations-graph helper script.
jezdez May 20, 2019
5737483
Update Circle CI for our workflow
robotblake Apr 19, 2017
e7822a2
Filter tables from schema browser (re #31)
Jul 9, 2018
665f360
Properly rollback failed db commits
Mar 21, 2018
15b4c16
Enable data source details component (re #6)
Sep 16, 2019
e4365e5
Schema Viewer Drawer (getredash#3291)
Mar 25, 2019
bd483d0
Use SIGKILL instead of SIGINT to shutdown cancelled jobs.
jezdez May 7, 2020
11e5253
Add new dynamic component to add extra menu items to query control dr…
jezdez May 26, 2020
2639bd7
Remove RC docker image build workflow from CircleCI configuration
jasonthomas Jun 11, 2020
827e5ab
Only load fields that are needed from Google API for Big Query schema.
jezdez Apr 3, 2019
6643b92
Schema Editor Fixes.
Oct 19, 2020
1eeb446
Remove admin integration.
jezdez Nov 12, 2020
9d0f454
Fixes for schema drawer.
jezdez Nov 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/app/pages/data-sources/EditDataSource.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import routeWithUserSession from "@/components/ApplicationArea/routeWithUserSess
import navigateTo from "@/components/ApplicationArea/navigateTo";
import LoadingState from "@/components/items-list/components/LoadingState";
import DynamicForm from "@/components/dynamic-form/DynamicForm";
import SchemaTable from "@/pages/data-sources/schema-table-components/SchemaTable";
import { SchemaTable } from "@/pages/data-sources/schema-table-components/SchemaTable";
import helper from "@/components/dynamic-form/dynamicFormHelper";
import HelpTrigger, { TYPES as HELP_TRIGGER_TYPES } from "@/components/HelpTrigger";
import wrapSettingsTab from "@/components/SettingsWrapper";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,33 @@ export class EditableCell extends React.Component {
super(props);
this.state = {
visible: this.props.record ? this.props.record.visible : false,
description: this.props.record ? this.props.record.description : "test"
};

}

onChange = () => {
this.setState(prevState => ({ visible: !prevState.visible }));
};

onChangeDesc = (e) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be necessary, I was testing some things out.

let newThing = e.target ? e.target.value : "";
this.setState(prevState => ({ description: newThing }));
};

getInput = () => {
if (this.props.input_type === "visible") {
return <TableVisibilityCheckbox visible={this.state.visible} onChange={this.onChange} />;
} else if (this.props.input_type === "sample_queries") {
return <SampleQueryList />;
}
return <TextArea className="table-textarea" placeholder="Enter description..." style={{ resize: "vertical" }} />;
return <TextArea
className="table-textarea"
style={{ resize: "vertical" }}
rows={3}
value={this.state.description}
onChange={this.onChangeDesc}
/>;
};

render() {
Expand All @@ -62,9 +75,11 @@ export class EditableCell extends React.Component {
return (
<td {...restProps}>
{editing ? (
<Form.Item style={{ margin: 0 }} name={dataIndex} initialValue={record[dataIndex]}>
{this.getInput()}
</Form.Item>
<Form>
<Form.Item style={{ margin: 0 }} name={dataIndex} initialValue={record[dataIndex]}>
{this.getInput()}
</Form.Item>
</Form>
) : (
restProps.children
)}
Expand Down
Loading