Implement spread for arrays#2098
Merged
Merged
Conversation
0xe
force-pushed
the
scratch/array-spread
branch
2 times, most recently
from
October 6, 2025 11:45
4ce9215 to
52dd712
Compare
0xe
force-pushed
the
scratch/array-spread
branch
from
October 7, 2025 08:21
17c664b to
959c4f5
Compare
0xe
commented
Oct 7, 2025
0xe
force-pushed
the
scratch/array-spread
branch
from
October 10, 2025 07:27
959c4f5 to
1b8f8a7
Compare
0xe
force-pushed
the
scratch/array-spread
branch
4 times, most recently
from
October 28, 2025 09:09
77d4e23 to
3ffbbda
Compare
0xe
marked this pull request as ready for review
October 28, 2025 09:09
rbri
reviewed
Oct 28, 2025
| // Per spec, if Symbol.iterator exists, use it. Let exceptions propagate. | ||
| final Object iterator = ScriptRuntime.callIterator(src, cx, scope); | ||
| if (!Undefined.isUndefined(iterator)) { | ||
| java.util.List<Object> spreadValues = new java.util.ArrayList<>(); |
0xe
force-pushed
the
scratch/array-spread
branch
from
October 28, 2025 11:50
3ffbbda to
03cf04a
Compare
Collaborator
|
@0xe have to do an HtmlUnit release first, will try this afterwards, maybe at he end of the week |
Collaborator
|
@0xe i like to do a smoke test for this with HtmlUnit, it will be great if you can rebase this to the head |
0xe
force-pushed
the
scratch/array-spread
branch
from
November 10, 2025 04:42
03cf04a to
c2573f2
Compare
Contributor
Author
|
I think the Android test failures are unrelated. I see errors trying to install the emulator: |
Collaborator
|
@0xe smoke test with HtmlUnit was successful! |
0xe
force-pushed
the
scratch/array-spread
branch
from
November 12, 2025 04:54
1712227 to
ea36fd6
Compare
Collaborator
|
This works for me and I don't see anything concerning. I'm going to merge it and keep moving forward. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
@andreabergia and I have been working on this for a while. We plan to tackle spread for function calls in a subsequent change.