Disambiguate local variable names to fix debugger issues.#2177
Merged
gbrail merged 4 commits intoDec 5, 2025
Conversation
rPraml
reviewed
Nov 28, 2025
| * is used. | ||
| */ | ||
| private static String[] disambiguateNames(String[] names, int paramCount) { | ||
| String[] result = new String[names.length]; |
Contributor
There was a problem hiding this comment.
How hot is this method?
Would it make sense to add a fast exit like if (names.length <= paramCount) return names to avoid some object creation
Contributor
Author
There was a problem hiding this comment.
It's called once per method during compilation, so not very hot.
Contributor
Author
|
Thanks to @andreabergia for adding a specific test around this≥ |
gbrail
reviewed
Nov 29, 2025
| varDbls[state.indexReg] = frame.sDbl[state.stackTop]; | ||
| } | ||
| } else { | ||
| // This only occurs if we are using the deubgger, in |
Collaborator
There was a problem hiding this comment.
Could you please fix this (repeated) typo? Thanks!
andreabergia
approved these changes
Dec 1, 2025
aardvark179
force-pushed
the
aardvark179-debugger-variables-fix
branch
2 times, most recently
from
December 1, 2025 12:17
5b3e7d8 to
d1e479a
Compare
aardvark179
force-pushed
the
aardvark179-debugger-variables-fix
branch
from
December 4, 2025 17:13
d1e479a to
b32314e
Compare
Collaborator
|
This is a nice fix -- thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problems seen with blocks and the debugger in #2174.