-
Notifications
You must be signed in to change notification settings - Fork 570
Refactor system/dist/CUDA tests #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The failing nvcc tests on Windows will be fixed by bug fixes in the follow-up PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2382 +/- ##
==========================================
- Coverage 71.41% 70.90% -0.52%
==========================================
Files 65 67 +2
Lines 36349 35623 -726
==========================================
- Hits 25960 25257 -703
+ Misses 10389 10366 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
i am not comfortable landing a change that would deliberately break the CI :/ |
@sylvestre #2383 branches from this PR, I just split them up per a request from @drahnr. #2383 has both sets of changes (diff of the two branches here), so it's fine to ignore this one and merge #2383 instead. I will also be adding |
cc: @robertmaynard for review |
My suggestions was to split out the structural test changes, I didn't say broken CI would be acceptable :) If there are specific tests that would be fixed later on, please defer them to the relevant other PR(s). |
The test improvements exposed an underlying bug, because now they compare fields that weren't compared before. I apologize if that wasn't clear before. The test changes are isolated to this PR to make them easier to review, but they are also included in the PR (#2383) that includes the fix. The diff of the test changes and the fix is here. The changes to the tests can be merged separately from the bug fix by merging this PR, then immediately merging #2383, or they can be merged together by closing this PR and only merging #2383. Let me know if there's anything I can do to make reviewing these easier. |
b307d9a
to
2470bab
Compare
…e into fea/enhance-system-tests
This PR extracts the test changes from #2356 per @drahnr's request.
The system and dist tests now use an
SccacheClient
instance (a519fc3), which is a struct that wraps an sccache client process. EachSccacheClient
instance starts its sccache client on a distinct port, and shuts it down whenSccacheClient
dropped.With this improvement, system (and dist) tests can now run in parallel. Since each test creates its own isolated
SccacheClient
instance, no need to carefully manage globalstart_local_daemon()
,stop_local_daemon()
,zero_stats()
etc. calls.The second commit (b307d9a) refactors the CUDA tests to be easier to read and update. Rather than individually asserting various struct fields match exact values, it's easier to create a
ServerStats
instance, increment the values I expect to change, and compare against the real stats.