Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update position for NEL (positive) #1141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update position for NEL (positive) #1141

wants to merge 1 commit into from

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Dec 9, 2024

Closes #99.

@zcorpan zcorpan requested a review from valenting December 9, 2024 15:32
@zcorpan zcorpan requested a review from martinthomson December 9, 2024 21:11
@tantek tantek requested a review from mozfreddyb December 16, 2024 17:19
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems I can see with this update having read the comment thread on #99:

1: should (likely) be overall 'neutral' not 'positive'.

I don't think "subset of spec is positive" is sufficient for a "positive" evaluation overall, but rather "neutral" at best if the positive at least somewhat offsets the negative.

Have we defined what that "subset" is?

Is there an issue open to reduce the spec to that subset?

If the spec is reduced to the positive subset, then we can re-evaluate as "positive".

This is something we should probably capture in a guide for s-p.

2: original evaluators/critics did not agree to change

Also unusual is that the flipping of position was not commented on or re-evaluated by any of the people who proposed the prior (negative) position.

E.g. I would want to at least see @mozfreddyb explicitly say he also thinks that that same subset is positive.

Even with that though, I would still conclude "neutral" per (1), unless Freddy was convinced that the subset is so positive that it overwhelming overrides remaining negative aspects of the spec (which btw, no one, not even @valenting's comment #99 (comment), has addressed).

"Some parts of this spec are positive" has NEVER been justification for a "positive" position.

Even changing this to "neutral" would require explicit reasoning and explanations why & how the benefits from the positive aspects sufficiently override the harms from the negative aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Error Logging (NEL)
3 participants