wip-sheriffed-frameworks #8661
Open
wip-sheriffed-frameworks #8661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatrice-acasandrei
force-pushed
the
wip-sheriffed-frameworks
branch
from
060e0c7 to
022b3b1
Compare
| @@ -418,6 +419,19 @@ def _timerange(self, queryset, name, value): | |||
| push__time__gt=datetime.datetime.utcfromtimestamp(int(time.time() - int(value))) | |||
| ) | |||
|
|
|||
| def _show_sheriffed_frameworks(self, queryset, name, value): | |||
There was a problem hiding this comment.
We should centralize them in a constant
| @@ -207,6 +212,9 @@ class AlertsView extends React.Component { | |||
| if (listMode && params.framework === doNotFilter) { | |||
| delete params.framework; | |||
| } | |||
| if (listMode && params.framework === -2) { | |||
There was a problem hiding this comment.
Add a comment to explain why we do this
beatrice-acasandrei
force-pushed
the
wip-sheriffed-frameworks
branch
from
022b3b1 to
039397e
Compare
| @@ -271,6 +279,10 @@ class AlertsView extends React.Component { | |||
| if (hideAssignedToOthers) { | |||
| params.with_assignee = user.username; | |||
| } | |||
| console.log(framework); | |||
| if (framework.id === -2) { | |||
There was a problem hiding this comment.
add comment that this is meant to be a ui artifice / workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.