WT-851 Update navigation state correctly on click#1242
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
==========================================
+ Coverage 79.25% 79.54% +0.28%
==========================================
Files 135 138 +3
Lines 8375 8574 +199
==========================================
+ Hits 6638 6820 +182
- Misses 1737 1754 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d36908a to
9e6dd16
Compare
9e6dd16 to
88ba464
Compare
|
I'll keep the labels in mind from now on :) |
|
it's not required, I do it for myself because I find the labels easier to see at a glance than whether or not the PR's in draft |
janriokrause
left a comment
There was a problem hiding this comment.
Tested and works for me, but leaving the approval to the front-end team.
💡 Idea: We could drop focusedMenu if we switch the mouse handler from click to pointerdown and add a keyboard keydown handler (Enter/Space). pointerdown fires before focus/click, so it avoids the focus -> click double‑toggle that caused the re‑open. Hover behavior stays the same.
One-line summary
The navigation bar closes and opens the panel when clicked instead of just closing. This is because is contains a focus handler as well as a click handler which both run when clicked.
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-851
Testing