Skip to content

Contact form improvements#1504

Open
maribedran wants to merge 6 commits into
mainfrom
contact-form-improvements
Open

Contact form improvements#1504
maribedran wants to merge 6 commits into
mainfrom
contact-form-improvements

Conversation

@maribedran

Copy link
Copy Markdown
Collaborator

One-line summary

Improve error handling on the Contact Page form and create a new Country Select block.

Significant changes and points to review

  • Indicate field errors with a message under the field and error styles on inputs
  • Add a notification in case the user has JS disabled
  • Create a new Country Select block with all country options gathered from Product Details

Issue / Bugzilla link

Testing

image
  • Manually edit the HTML to trigger an invalid form submission (the browser by default won't let you submit the form) - remove the required attribute from the form fields or delete them entirely and submit the form
image image
  • Make sure you don't have Basket running to trigger an API error and submit a valid form. Check that the error message appears
image

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.92%. Comparing base (0683fc5) to head (605e801).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
springfield/cms/models/pages.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
+ Coverage   80.90%   80.92%   +0.02%     
==========================================
  Files         147      147              
  Lines       10133    10144      +11     
==========================================
+ Hits         8198     8209      +11     
  Misses       1935     1935              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant