Skip to content

Do not use utc_now on module level #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025
Merged

Do not use utc_now on module level #372

merged 5 commits into from
May 28, 2025

Conversation

sobolevn
Copy link
Contributor

Looks like that this value is never used anywhere, and it should not be, because it is created once on a module import time.

I found this while working on python/typeshed#13514

Looks like that this value is never used anywhere, and it should not be, because it is created once on a module import time.

I found this while working on python/typeshed#13514
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (4b0701b) to head (3af0a8d).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
jose/jwt.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   92.69%   92.70%           
=======================================
  Files          15       15           
  Lines        1424     1439   +15     
=======================================
+ Hits         1320     1334   +14     
- Misses        104      105    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asherf asherf merged commit ceaac36 into mpdavis:master May 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants