Post一覧取得時のN+1問題と解消 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[修正理由] Post一覧画面の`_comment.html.erb`で毎回`User Load`を読んでいることが判明した。 上記の原因は、行ごとにcomment.userを参照してるため、include or preloadを使用しないとコメント数分`users`を個別selectしてしまう。 そのため、一覧取得に事前に関連情報をpreloadする必要がある。
mpg-yuta-goto
changed the title
mpg-yuta-goto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 概要
User Loadを読んでいることが判明した。 上記の原因は、行ごとにcomment.user.nameを参照してるため、include or preloadを使用しないとコメント数分usersを個別selectしてしまう。そのため、一覧取得に事前に関連情報を
preloadする処理を追加した。tagに関しても同様です🙇🔍 変更内容
✅ 動作確認
📸 スクリーンショット
User1クエリでまとめて取得できている
Tag5件のpost分を一括で取得できている
💬 補足