Detailed tracing #54
Open
Detailed tracing #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was too complicated to pass around the sessionSpan, and it is better done with just wrapping the request handler in a span
The target filename is available here, so we can put it in the OpenTelemetry tags instead of the span name.
|
Can you rebase and make the MR on top of https://github.com/wz1000/ghcide/tree/hls-2 ? You can either use that or digitalasset/master |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request adds tracing to
It also moves the filename of action traces to the OpenTelemetry tags, making the traces easier to grok and facilitating automated analysis of traces.