Add JSON import feature with four-phase validation#269
Open
rburman-tech wants to merge 1 commit into
Open
Conversation
- Pure validateImport() function (4 phases: structure, schema, ID references, coordinates) with 40 passing tests - Import modal with raw JSON download (no translateEntities), file picker, per-field error display, and upload flow - Import thunk remaps faction homeworld/asset location IDs after Cloud Function returns mapping - Import button added to ActionLayout sidebar (saved, non-shared sectors only) - Redux state for isImportOpen + i18n keys added to 6 language files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the round-trip gap opened by #268 (export now includes routes, layers, factions).
What this adds
Design notes
The validator is a pure function (no Firestore reads) so it can be tested exhaustively and fails cleanly before touching any data. Raw JSON format is required for import because translateEntities localizes attribute values — reimporting a translated export would corrupt the app.