fix: correct jakim_code for 4 districts in Perak and Sarawak#5
Open
nurulizyansyaza wants to merge 1 commit into
Open
fix: correct jakim_code for 4 districts in Perak and Sarawak#5nurulizyansyaza wants to merge 1 commit into
nurulizyansyaza wants to merge 1 commit into
Conversation
Cross-referenced jakim_code values against official JAKIM zone-district mapping from the Takwim Solat reference document: https://www.e-solat.gov.my/index.php?siteId=24&pageId=43 and JAKIM e-Solat API (https://www.e-solat.gov.my) Fixes: - Kerian (Perak): PRK01 → PRK06 - Kinta (Perak): PRK01 → PRK02 - Hilir Perak (Perak): PRK02 → PRK05 - Bukit Mabong (Sarawak): SWK03 → SWK04
There was a problem hiding this comment.
Pull request overview
Updates JAKIM e-Solat zone codes in the district-level GeoJSON to match the official JAKIM zone↔district mapping (Perak + Sarawak), ensuring downstream consumers (e.g., prayer time lookups) use the correct zone identifiers.
Changes:
- Corrected
jakim_codefor Bukit Mabong (Sarawak) fromSWK03toSWK04. - Corrected
jakim_codefor Hilir Perak, Kerian, and Kinta (Perak) toPRK05,PRK06, andPRK02respectively.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks for the PR and apologies for didn't notice this earlier. Will review it by today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-referenced jakim_code values against official JAKIM zone-district mapping from the Takwim Solat reference document:
https://www.e-solat.gov.my/index.php?siteId=24&pageId=43 and JAKIM e-Solat API (https://www.e-solat.gov.my)
Fixes: