Skip to content

Conversation

@Ckath
Copy link
Contributor

@Ckath Ckath commented Nov 1, 2025

this happened right after going to the next file. the playlist would be fine when staying on the first file. with logging you can see it 'prepending' the file it was just on.

traced it back to it this behaviour appearing since 5de1f5a
the fix to just throw the current file in the added_entries right away seems to work fine in all scenarios I could think and test

@Ckath
Copy link
Contributor Author

Ckath commented Nov 1, 2025

not only is the script obsolete, I also messed up the commit message

cheers

@Ckath Ckath closed this Nov 1, 2025
@llyyr
Copy link
Contributor

llyyr commented Nov 1, 2025

Please reopen this, I think it's still useful to fix issues with the script. If it was obsolete it would be removed from the repo.

this happened right after going to the next file
@Ckath
Copy link
Contributor Author

Ckath commented Nov 2, 2025

sure. after initial discussion in the irc it did seem the --autocreate-playlist=filter works for 'most' cases but some stuff is still not 100% there so I guess there is value in keeping it working if its still in the repo.

@Ckath Ckath reopened this Nov 2, 2025
@kasper93
Copy link
Member

kasper93 commented Nov 3, 2025

--autocreate-playlist=filter works for 'most' cases but some stuff is still not 100% there

Could you link to the issues with autocreate-playlist that are not 100% there?

@na-na-hi
Copy link
Contributor

na-na-hi commented Nov 3, 2025

Could you link to the issues with autocreate-playlist that are not 100% there?

  • It does not react to newly added files in a directory after files are autoloaded, while autoload.lua does.
  • Does not support ignore_hidden. It is hardcoded to always ignore hidden files.
  • The above also causes buggy behavior that hidden files cannot be played when using autocreate-playlist even when the file is specified in the commandline to open (it just opens another file instead), while autoload.lua plays the file as expected.
  • Does not support ignore_patterns.

@kasper93
Copy link
Member

kasper93 commented Nov 3, 2025

Could you link to the issues with autocreate-playlist that are not 100% there?

* It does not react to newly added files in a directory after files are autoloaded, while `autoload.lua` does.

* Does not support `ignore_hidden`. It is hardcoded to always ignore hidden files.

* The above also causes buggy behavior that hidden files cannot be played when using `autocreate-playlist` even when the file is specified in the commandline to open (it just opens another file instead), while `autoload.lua` plays the file as expected.

* Does not support `ignore_patterns`.

Could you create issues for those?

@Ckath Ckath changed the title stop initial file from being added twice autoload.lua: stop initial file from being added twice Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants