console.lua: avoid empty lines at the bottom of menu after resizing the window #17198
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidocella
approved these changes
Dec 29, 2025
verygoodlee
force-pushed
the
console-menu-fix
branch
from
78d35cf to
d7c14f6
Compare
with `scale_with_window=no` script option, `first_match_to_print` increases when shrinking the window and no longer decreases when expanding the window, causing empty lines at the bottom of menu and a chain reaction of the script crashing due to the mouse wheel scrolling up. this commit trys to decrease `first_match_to_print` when its value is abnormal. Closes mpv-player#16682
verygoodlee
force-pushed
the
console-menu-fix
branch
from
d7c14f6 to
bb4f03b
Compare
|
Download the artifacts for this pull request: Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with
scale_with_window=noscript option,first_match_to_printincreases when shrinking the window and no longer decreases when expanding the window, causing empty lines at the bottom of menu and a chain reaction of the script crashing due to the mouse wheel scrolling up.this commit trys to decrease
first_match_to_printwhen its value is abnormal.Closes #16682