player/video: forget vo frames on video state reset #17207
Closed
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may not receive next draw call after reset and it is still important to flush existing frames.
When filters return hw frames, we may not hold reference to the parent context, for most API it's not a problem, because they are all refcounted, but AMF in ffmpeg forcefully dlclose() on uninit(), so we need to make sure any hw frames are flushed before this happens. Fixes: mpv-player#17206
6 tasks
Member
I investigated this in the context of FFmpeg/FFmpeg@954784b and PR #14631 and was told by ffmpeg developers that holding a reference to frames is a valid thing to do and should always work. |
|
Download the artifacts for this pull request: Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.