Explicitly allow openArray in Tensor [], []=, fix the CI
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was simply an oversight obviously
By not resetting the offset here, operating on a Tensor view without cloning could cause undefined behavior, because we would be accessing elements outside the tensor buffer.
Collaborator
Author
|
Merging, because OSX CI is still borked. |
metagn
pushed a commit
to metagn/Arraymancer
that referenced
this pull request
Mar 29, 2025
…im#666) * explicitly allow `openArray` in `[]`, `[]=` for tensors This was simply an oversight obviously * fix CI by compiling tests with `-d:ssl` * need a space, duh * use AWS mirror from PyTorch for MNIST download * fix regression caused by PR mratsim#659 By not resetting the offset here, operating on a Tensor view without cloning could cause undefined behavior, because we would be accessing elements outside the tensor buffer. * add test case for regression of mratsim#659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the more type safe approach to
[],[]=in #653 I also forgot to addopenArrayto the allowed types.This should also fix the CI by compiling with
-d:sslto download the MNIST dataset.edit:
Also fixes a regression that appeared as a result of PR #659. See the added test case and commits.