Skip to content

Fix least squares solver #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mratsim merged 1 commit into from
Nov 10, 2025
Merged

Fix least squares solver #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/arraymancer/linear_algebra/helpers/least_squares_lapack.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ proc gelsd*[T: SomeFloat](
const smlsiz = 25'i32 # equal to the maximum size of the subproblems at the bottom of the computation tree
let
minmn = min(m,n).int
nlvl = max(0, (minmn.T / (smlsiz+1).T).ln.int32 + 1)
nlvl = max(0, (minmn.T / (smlsiz+1).T).log2.int32 + 1)
# Bug in some Lapack, liwork must be determined manually: http://icl.cs.utk.edu/lapack-forum/archives/lapack/msg00899.html
liwork = max(1, 3 * minmn * nlvl + 11 * minmn)

Expand Down
Loading