Mrc 6873 variable width legend #257
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the general strategy is to collect up all the labels that can appear on the legend (excluded those that are hidden in the graph config) and fill in a paragraph tag one by one and find the longest width, we then set the legend text width equal to that
this should ensure that the legend width is the same across all different graphs and never longer than it needs to be because it ignores hidden variables
unfortunately, this is another one of those features thats hard to test, i cant really test the width value at all because the width depends on font family, font size, text content, which can all change, a test that checks the numerical value of the width is far too brittle