Skip to content

build: begin using flake-parts feautures more and also compress lockfile #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DockterTeagle
Copy link

as mentioned in the discussion posts this is to use more of flake-parts and also compress lockfile, feel free to ignore or close.

Copy link
Contributor

github-actions bot commented May 5, 2025

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@DockterTeagle
Copy link
Author

why did you call it pre-commit check if it isnt applied at pre-commit? also I forgot to check, and for some reason changing to the new URL breaks lua checks?

@DockterTeagle
Copy link
Author

where is pkgs.nvim-nightly-tests defined? I am trying to make sense of the devshell and to also figure out why tests are failing

@DockterTeagle
Copy link
Author

so one of a few things happened,
A. these tests have been failing all the time, but are only now showing up(they are warnings)
B. cachix changed the lib to make it not the same(I cant find pre-commit-hooks.nix anywhere)
C. I have entered psychosis from lack of sleep, and
D. I am somehow messing up the liib

@DockterTeagle
Copy link
Author

after further reflection I think that the lsp or the luarc got updated win regards to neotest and code_Action causing these warnings

@DockterTeagle DockterTeagle marked this pull request as ready for review May 5, 2025 10:07
@mrcjkb
Copy link
Owner

mrcjkb commented May 5, 2025

why did you call it pre-commit check if it isnt applied at pre-commit? also I forgot to check, and for some reason changing to the new URL breaks lua checks?

It is, in the devShell. The repo was renamed to git-hooks.nix though.

@DockterTeagle
Copy link
Author

sorry misclick not fully ready

@mrcjkb
Copy link
Owner

mrcjkb commented May 5, 2025

I'll have to look at this at a later time.

@DockterTeagle
Copy link
Author

fair enough, this would be my first time contributing to anything of note, so I want it to be correct

plugin-overlay
];
};
# overlayAttrs = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overlayAttrs is trying to use the easy overlay provided by flake-parts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it commented as a note to use it later, if you are willing to, and also I dont think that it is that much of an improvement.

@mrcjkb
Copy link
Owner

mrcjkb commented May 5, 2025

after further reflection I think that the lsp or the luarc got updated win regards to neotest and code_Action causing these warnings

Yep, that happens sometimes.
Often, it's enough to add a ---@diagnostic disable-next-line comment (if it's not an actual type check error that was missed by previous lua-ls versions).

@mrcjkb
Copy link
Owner

mrcjkb commented May 5, 2025

This is not a feature. The correct commit prefix would be build:.

@DockterTeagle
Copy link
Author

ah, thought feat meant like well a feat, but you are right. will rename later after thermo final in approximately 5 hours

@DockterTeagle DockterTeagle changed the title feat: begin using flake-parts feautures more and also compress lockfile build: begin using flake-parts feautures more and also compress lockfile May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants