-
-
Notifications
You must be signed in to change notification settings - Fork 95
build: begin using flake-parts feautures more and also compress lockfile #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
why did you call it pre-commit check if it isnt applied at pre-commit? also I forgot to check, and for some reason changing to the new URL breaks lua checks? |
where is pkgs.nvim-nightly-tests defined? I am trying to make sense of the devshell and to also figure out why tests are failing |
so one of a few things happened, |
after further reflection I think that the lsp or the luarc got updated win regards to neotest and code_Action causing these warnings |
It is, in the devShell. The repo was renamed to git-hooks.nix though. |
sorry misclick not fully ready |
I'll have to look at this at a later time. |
fair enough, this would be my first time contributing to anything of note, so I want it to be correct |
plugin-overlay | ||
]; | ||
}; | ||
# overlayAttrs = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overlayAttrs is trying to use the easy overlay provided by flake-parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it commented as a note to use it later, if you are willing to, and also I dont think that it is that much of an improvement.
Yep, that happens sometimes. |
This is not a feature. The correct commit prefix would be |
ah, thought feat meant like well a feat, but you are right. will rename later after thermo final in approximately 5 hours |
as mentioned in the discussion posts this is to use more of flake-parts and also compress lockfile, feel free to ignore or close.