feat: consolidate theme handling and add 2 more #39
Conversation
the flicker is still there but its during the closing animation instead of after
|
d3289ba addresses the issue where an invalid theme name caused the page to error out completely, this came up while switching branches and where the theme i was using wasn't in main |
|
@yz778 I am not sure there is value in adding all the themes, it creates a lot more visual tests to make sure everything looks okay. Also some of them are just weird lol. Is there a specific theme from daisyui that you're hoping to use? |
|
I've updated it to be configurable (see I understand the regression concerns -- maybe have a few "official" themes and then just leave it up to user to choose something else. Personally I open a few different windows and having a few more customizable choices is fun: |
|
@yz778 unfortunately I don't think this change is going to make it into the main branch. A lot of the themes have strange colors and also change the border radiuses. If there is a particular color scheme, or maybe 2 that you're very interested in, I'm definitely willing to discus, but I can't fathom the maintenance requirements to support the whole suite of themes. Especially when daisy is only part of the UI colors and so themes like aqua would make the UI unreadable. I do apologize because I see you put a lot of work into this but I would like to leave the colors as is for now 🙏 |
|
Yep no problem. One thing I'd suggest is perhaps still reusing some aspects
of this b/c in the existing code the theme names are hardcoded across
multiple files. You could still use this code and comment out/remove all
the theme entries you don't want.
…On Tue, Jul 8, 2025 at 10:56 AM DJ Johnson ***@***.***> wrote:
*mrdjohnson* left a comment (mrdjohnson/llm-x#39)
<#39 (comment)>
@yz778 <https://github.com/yz778> unfortunately I don't think this change
is going to make it into the main branch. A lot of the themes have strange
colors and also change the border radiuses.
If there is a particular color scheme, or maybe 2 that you're very
interested in, I'm definitely willing to discus, but I can't fathom the
maintenance requirements to support the whole suite of themes.
Especially when daisy is only part of the UI colors and so themes like
aqua would make the UI unreadable.
I do apologize because I see you put a lot of work into this but I would
like to leave the colors as is for now 🙏
—
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARXEJL6BMLS7MOPFJETFIL3HQA45AVCNFSM6AAAAACBAI5VIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBZHAZDONBQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
If you can consider "nord" and "synthwave", that'd be greatly appreciated. |
yz778
changed the title
I'm looking into it, the reason it was hardcoded is because there are so few and zero plans for more 😅 |
2 participants
No description provided.