Skip to content

Conversation

@jayschwa
Copy link
Contributor

This makes the method consistent with most other vector transformations, and will make it easier to include it in a chain of operations.

This makes the method consistent with most other vector transformations, and will make it easier to include it in a chain of operations.
@WestLangley
Copy link
Collaborator

Thanks. If you are changing the API, then the docs need to be updated, too.

@looeee has been very helpful with that.

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 21, 2018

I think it's useful to merge this PR. Currently the method returns undefined which seems not very consistent.

BTW: The change for docs/api/textures/Texture.html is not 100% correct since the return type should be added at the method's title. It should look like this:

<h3>[method:Vector2 transformUv]( uv )</h3>

@jayschwa Still interested? 😉

@mrdoob mrdoob merged commit c6354ae into mrdoob:dev Aug 21, 2018
@mrdoob
Copy link
Owner

mrdoob commented Aug 21, 2018

Merged and fixed.

@mrdoob
Copy link
Owner

mrdoob commented Aug 21, 2018

Thanks!

@mrdoob mrdoob added this to the r96 milestone Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants