Add webgl2 message on Detector #14504
Conversation
examples/webgl2_sandbox.html
Outdated
|
|
||
| // | ||
|
|
||
| if ( ! Detector.webgl2 ) Detector.addGetWebGLMessage( { version: 'webgl2' }); |
There was a problem hiding this comment.
I think I would add Detector.addGetWebGL2Message() instead in order to avoid the parameter object.
There was a problem hiding this comment.
@Mugen87 @mrdoob what do you think about adding a addGetWebGLMessageByVersion to avoid duplicating code?
addGetWebGLMessageByVersion: function ( parameters, version ) {
var parent, id, element;
parameters = parameters || {};
parent = parameters.parent !== undefined ? parameters.parent : document.body;
id = parameters.id !== undefined ? parameters.id : 'oldie';
element = Detector.getWebGLErrorMessage( version );
element.id = id;
parent.appendChild( element );
},
addGetWebGL2Message: function ( parameters ) {
Detector.addGetWebGLMessageByVersion( parameters, 'webgl2' );
},
addGetWebGLMessage: function ( parameters ) {
Detector.addGetWebGLMessageByVersion( parameters, 'webgl' );
}Do you think we should do something similar with Detector.getWebGLErrorMessage/getWebGL2ErrorMessage ?
There was a problem hiding this comment.
what do you think about adding a addGetWebGLMessageByVersion to avoid duplicating code?
I think that's fine. But I would name it _addGetWebGLMessageByVersion() or make a function instead (and move the whole code into a closure).
Do you think we should do something similar with Detector.getWebGLErrorMessage/getWebGL2ErrorMessage ?
If it makes the code easier to read, why not? 😊
|
/friendly-ping @mrdoob |
|
Ended up refactoring Detector.js completely. #14967 |
4 participants
Modified the
Detector.addGetWebGLMessageso you could pass{version: 'webgl2'}and it will create the correct message and link to https://get.webgl.org/webgl2