Texture3d support #14530

artur-trzesiok · 2018-07-23T14:13:23Z

Working example from K3D-jupyter:

moraxy · 2018-07-23T14:49:39Z

nevermind :sweat_smile:

takahirox · 2018-07-23T22:48:35Z

Nice work. Can you make and add an 3D texture example under examples/?

artur-trzesiok · 2018-07-24T20:04:05Z

Probably. I don't have time right now to do this. I will try during a weekend.

Mugen87 · 2018-07-25T10:05:34Z

Adding a new doc page would also be great. BTW: What would happen if the user uses Texture3D with a WebGL 1 context? It's maybe a good idea to detect this and provide an informative warning.

takahirox · 2018-07-25T13:16:40Z

I'm thinking how TextureLoader supports 3D texture. I'm not familiar with 3D texture yet. Can we detect if image is for 3D texture from the filename extension or something?

takahirox · 2018-07-27T10:18:34Z

src/renderers/webgl/WebGLUtils.js

 		if ( p === LuminanceAlphaFormat ) return gl.LUMINANCE_ALPHA;
 		if ( p === DepthFormat ) return gl.DEPTH_COMPONENT;
 		if ( p === DepthStencilFormat ) return gl.DEPTH_STENCIL;
+		if ( p === RedFormat ) return gl.RED;


gl.RED is available only in WebGL2 so I think we need to check if gl is WebGL2RenderingContext.

if ( capabilities.isWebGL2 && p === RedFormat ) return gl.RED;

takahirox · 2018-07-27T10:20:35Z

src/renderers/webgl/WebGLUniforms.js

 import { Texture } from '../../textures/Texture.js';

 var emptyTexture = new Texture();
+var emptyTexture3d = new Texture();


Isn't here new Texture3D()?

Probably 👍

takahirox · 2018-07-27T10:55:08Z

src/textures/Texture3D.js

+
+	Texture.call( this, null, mapping, wrapS, wrapT, magFilter, minFilter, format, type, anisotropy, encoding );
+
+	this.image = { data: data, width: width, height: height, length: length };


Is there any reasons why you're targeting only data texture, not image texture?

Very simple reason - i only need a data texture. On the other hand - writing support for 3d images dataformat is a separate task from my point of view.

OK. Then I think module name DataTexture3D would sound more natural than Texture3D in this PR.

Would there be a significant difference between a DataTexture3D and just a Texture3D in this case? The width, height, and depth need to be separately specified even if using an image to bind data:
https://developer.mozilla.org/en-US/docs/Web/API/WebGL2RenderingContext/texImage3D

As a little bit of an aside, how is the data interpreted when binding a 2d image as a texture 3d?

DavidPeicho · 2018-07-30T23:58:00Z

I am still not convinced about the automatic deduction of the internal format. In my case for instance, I use particular texture with internal format, such as RG8UI. Maybe we could find a good way to add this internal format somewhere. What do you think? @takahirox

artur-trzesiok · 2018-07-31T12:16:06Z

New examples:

DavidPeicho · 2018-07-30T14:58:13Z

src/textures/Texture3D.js

+
+	Texture.call( this, null, mapping, wrapS, wrapT, magFilter, minFilter, format, type, anisotropy, encoding );
+
+	this.image = { data: data, width: width, height: height, length: length };


Does not depth make more sense than length?

fwiw Unity calls this dimension depth on their Texture3D

DavidPeicho · 2018-07-30T15:01:08Z

src/renderers/webgl/WebGLTextures.js


 		if ( ! _gl.isWebGL2 ) return glFormat;

+		if ( glFormat === _gl.RED ) {


What happens if I need a RG16F?

gkjohnson · 2018-07-31T16:25:07Z

This is awesome! Are there common standardized formats for 3d textures?

takahirox · 2018-08-06T16:28:28Z

Can you add an example under examples/? https://github.com/mrdoob/three.js/tree/dev/examples in this PR? Users and developers can see 3D texture works on Three.js.

takahirox · 2018-08-31T12:29:52Z

I locally made some examples

and confirmed this PR seems working.

@artur-trzesiok seems to have been busy. So I wanna suggest to merge this PR so far. And we do renaming, adding an example, writing documents, brushing up, and so on in other PRs.

takahirox · 2018-08-31T16:26:01Z

Currently no 3D texture(sampler3D and texture( sampler3D, vec3 )) in default shaders. So users must use [Raw]ShaderMaterial for 3D texture. I think it's good start. I heard major use cases of 3D texture are Volume rendering and sometimes gpgpu. In general users write their shader codes for them.

This leads to a question to me. (I'm studying but still new to 3D texture.) Are there any other use cases and/or do we need to have material which can handle 3D texture?

mrdoob · 2018-08-31T21:52:20Z

@artur-trzesiok seems to have been busy. So I wanna suggest to merge this PR so far. And we do renaming, adding an example, writing documents, brushing up, and so on in other PRs.

Sounds good!

mrdoob · 2018-08-31T21:52:31Z

Thanks!

mrdoob · 2018-08-31T22:01:50Z

src/renderers/WebGLRenderer.js


 	}() );

+	this.setTexture3D = ( function () {


@takahirox we can probably remove this as this function?

You meant we can simply write as the following? If yes, I think so.

this.setTexture3D = function ( texture, slot ) { textures.setTexture3D( texture, slot ); };

almarklein · 2018-09-03T13:23:24Z

FWIW I also made a volume rendering example, which I proposed as a PR against @artur-trzesiok 's branch: K3D-tools#1

takahirox · 2018-09-03T13:50:14Z

Cool. Do you also want to make PR to Three.js?

almarklein · 2018-09-03T14:51:04Z

Sure, I can do that.

takahirox · 2018-09-04T09:00:48Z

Wondering if we can have two 3D Texture examples.

One is @almarklein 's example. Users can see how nice 3D Texture + Volume rendering is. And users could reuse volume rendering shaders.

Another one is based on my simple and light example https://twitter.com/superhoge/status/1034875111923482625 Users can know how to use 3D Texture in Three.js.

Sounds good?

mrdoob · 2018-09-04T16:46:40Z

Sounds good!

artur-trzesiok added 3 commits July 23, 2018 16:12

Texture3d support

80dcd17

Texture3d support - style fix

1b4a538

Texture3d support - style fix

22515f0

artur-trzesiok added 4 commits July 23, 2018 16:50

Texture3d support

b1c8931

Merge remote-tracking branch 'origin/dev' into dev

27db773

Merge remote-tracking branch 'origin/dev' into dev

7fe4a31

Merge remote-tracking branch 'origin/dev' into dev

a838060

artur-trzesiok mentioned this pull request Jul 23, 2018

Volume rendering support K3D-tools/K3D-jupyter#22

Closed

takahirox mentioned this pull request Jul 23, 2018

WebGLRenderer WebGL2.0 initial support with GLSL 1 to 3 runtime conversion #13717

Merged

mrdoob added this to the r96 milestone Jul 25, 2018

takahirox reviewed Jul 27, 2018

View reviewed changes

DavidPeicho reviewed Jul 31, 2018

View reviewed changes

almarklein mentioned this pull request Aug 9, 2018

Volume rendering example K3D-tools/three.js#1

Closed

mrdoob modified the milestones: r96, r97 Aug 29, 2018

mrdoob merged commit 118ef7c into mrdoob:dev Aug 31, 2018

mrdoob reviewed Aug 31, 2018

View reviewed changes

takahirox mentioned this pull request Sep 3, 2018

3D Texture minor update #14839

Merged

almarklein mentioned this pull request Sep 4, 2018

Volume rendering example using 3D texture #14847

Merged

3 tasks

takahirox mentioned this pull request Sep 21, 2018

3D Texture simple example #14951

Merged

takahirox added the WebGL2 label Sep 26, 2018


		Texture.call( this, null, mapping, wrapS, wrapT, magFilter, minFilter, format, type, anisotropy, encoding );

		this.image = { data: data, width: width, height: height, length: length };


		if ( ! _gl.isWebGL2 ) return glFormat;

		if ( glFormat === _gl.RED ) {

Uh oh!

Texture3d support #14530

Texture3d support #14530

Uh oh!

Conversation

artur-trzesiok commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moraxy commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

takahirox commented Jul 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artur-trzesiok commented Jul 24, 2018

Uh oh!

Mugen87 commented Jul 25, 2018

Uh oh!

takahirox commented Jul 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artur-trzesiok Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

takahirox Jul 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DavidPeicho commented Jul 30, 2018

Uh oh!

artur-trzesiok commented Jul 31, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkjohnson commented Jul 31, 2018

Uh oh!

takahirox commented Aug 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

takahirox commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

takahirox commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrdoob commented Aug 31, 2018

Uh oh!

mrdoob commented Aug 31, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

almarklein commented Sep 3, 2018

Uh oh!

takahirox commented Sep 3, 2018

Uh oh!

almarklein commented Sep 3, 2018

Uh oh!

takahirox commented Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrdoob commented Sep 4, 2018

Uh oh!

Reviewers

Assignees

artur-trzesiok commented Jul 23, 2018 •

edited

Loading

moraxy commented Jul 23, 2018 •

edited

Loading

takahirox commented Jul 23, 2018 •

edited

Loading

artur-trzesiok Jul 31, 2018 •

edited

Loading

takahirox Jul 31, 2018 •

edited

Loading

takahirox commented Aug 6, 2018 •

edited

Loading

takahirox commented Aug 31, 2018 •

edited

Loading

takahirox commented Aug 31, 2018 •

edited

Loading

takahirox commented Sep 4, 2018 •

edited

Loading