Rename WebGLProgram "code" to "cacheKey" #17748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Oletus
force-pushed
the
rename-program-code
branch
from
fc806ba to
f964ded
Compare
Collaborator
I know what you mean but the term "hash" would better fit with the following implementation #16674. The PR computes a CRC32 value which is something that can be considered as an actual hash value. I think I vote for |
This name is clearer since "code" can be easily confused to mean shader code in this context. Settling on a good name here is important because we want to expose the ability to customize the cache key through the API.
Oletus
force-pushed
the
rename-program-code
branch
from
f964ded to
91d02e7
Compare
Contributor
Author
|
Cool, I'm happy with "cacheKey". Pushed an amended commit changing the name to cacheKey instead. |
Mugen87
approved these changes
Oct 17, 2019
Mugen87
changed the title
Contributor
Author
|
@mrdoob Please merge! |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This name is clearer since "code" can be easily confused to mean shader code in this context.
Settling on a good name here is important because we want to expose the ability to customize the hash through the API. ( #17567 )