Skip to content

FBXLoader: Use getHandler() for custom texture loaders. #31032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 5, 2025
Merged

FBXLoader: Use getHandler() for custom texture loaders. #31032

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f10afbd
add capable of custom texture loader
tatsuya-ogawa Apr 30, 2025
3b804e8
replace factory to setXXXLoader
tatsuya-ogawa May 2, 2025
74b6d4c
Update FBXLoader.js
tatsuya-ogawa May 2, 2025
8bc59f2
fix indent
tatsuya-ogawa May 2, 2025
0a6e98e
use manager.getHandler
tatsuya-ogawa May 2, 2025
d338b21
fix loader variable name
tatsuya-ogawa May 2, 2025
e400684
fix url
tatsuya-ogawa May 2, 2025
d79a1e1
use getHandler for all extensions
tatsuya-ogawa May 2, 2025
1fe1dfb
Merge branch 'dev' of https://github.com/mrdoob/three.js into fbxload…
tatsuya-ogawa May 2, 2025
80ddfbc
Update FBXLoader.js
Mugen87 May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions examples/jsm/loaders/FBXLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,21 +437,10 @@ class FBXTreeParser {
// load a texture specified as a blob or data URI, or via an external URL using TextureLoader
loadTexture( textureNode, images ) {

const nonNativeExtensions = new Set( [ 'tga', 'tif', 'tiff', 'exr', 'dds', 'hdr', 'ktx2' ] );

const extension = textureNode.FileName.split( '.' ).pop().toLowerCase();

const loader = nonNativeExtensions.has( extension ) ? this.manager.getHandler( `.${extension}` ) : this.textureLoader;

if ( ! loader ) {

console.warn(
`FBXLoader: ${extension.toUpperCase()} loader not found, creating placeholder texture for`,
textureNode.RelativeFilename
);
return new Texture();

}
let loader = this.manager.getHandler( `.${extension}` );
if ( loader === null) loader = this.textureLoader;

const loaderPath = loader.path;

Expand Down