Addons: Remove PeppersGhostEffect.
#31037
Merged
+0
−302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
The PR removes
PeppersGhostEffectand the respective demo.The example is visually not appealing and also hard to grasp since you need to read the linked article to understand what is actually rendered. Besides, you would need to place a four-sided, reflective prism on top on your screen to achieve a full 3D display (the actual result of
PeppersGhostEffect).IMO, this is a too specific and unusual use case for the library. If developers want to implement something like that, they can work with the original article which demonstrates the effect with three.js sample code.