Allow set_comment to work with no decompiler available #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hex-Rays init_hexrays_plugin returns True if you have any decompilers. As far as I know, there's no API to ask if any support our current target. So catch the error and bail out.
mrexodia
requested changes
Jun 11, 2025
| # Reference: https://cyber.wtf/2019/03/22/using-ida-python-to-analyze-trickbot/ | ||
| # Check if the address corresponds to a line | ||
| cfunc = decompile_checked(address) | ||
| try: |
There was a problem hiding this comment.
This will hide a real decompilation error. Did you observe ida_hexrays.init_hexrays_plugin() succeeding but the decompilation failing if you do not have a decompiler available?
There was a problem hiding this comment.
If you have a HexRays decompiler but not the right decompiler for the executable , the init function still returns true.
For example, I hit this when reversing an x86 binary but I only have the x64 and ARM64 decompilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you do not have a decompiler for the platform, the
set_commentfunction fails.This PR adds a check to see if the hex rays plugin has been initialized and only sets the function comment if not.