Add stack variable support #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexodia
requested changes
Jun 11, 2025
| @idaread | ||
| def get_stack_frame_variables( | ||
| function_address: Annotated[str, "Address of the disassembled function to retrieve the stack frame variables"] | ||
| ) -> list[dict]: |
There was a problem hiding this comment.
Please return a TypedDict with the appropriate dict members.
| @@ -501,6 +502,73 @@ def create_demangled_to_ea_map(): | |||
| if demangled: | |||
| DEMANGLED_TO_EA[demangled] = ea | |||
|
|
|||
|
|
|||
| def get_type_by_name(type_name: str) -> ida_typeinf.tinfo_t: | |||
There was a problem hiding this comment.
Isn't there a way to directly go from name -> tinfo_t? I vaguely remember you can use one of the constructors for this.
| size = udm.size // 8 | ||
| type = str(udm.type) | ||
|
|
||
| members += [{'name': name, 'offset': hex(offset), 'size': hex(size), 'type': type}] |
There was a problem hiding this comment.
Would prefer formatting this with a key per line. Also use " instead of '`' to match the existing codebase.
|
|
||
| @jsonrpc | ||
| @idaread | ||
| def get_defined_structures() -> list[dict]: |
There was a problem hiding this comment.
TypedDict for structure definition.
| raise IDAError(f"{old_name} is an argument member. Will not change the name.") | ||
|
|
||
| sval = ida_frame.soff_to_fpoff(func, offset) | ||
| return ida_frame.define_stkvar(func, new_name, sval, udm.type) |
There was a problem hiding this comment.
I think it will be better to return None and then raise IDAError("failed to define stack variable") to get more actionable error messages.
| offset: Annotated[str, "Offset of the stack frame variable"], | ||
| variable_name: Annotated[str, "Name of the stack variable"], | ||
| type_name: Annotated[str, "Type of the stack variable"] | ||
| ) -> bool: |
| function_address: Annotated[str, "Address of the disassembled function to set the stack frame variables"], | ||
| variable_name: Annotated[str, "Name of the stack variable"], | ||
| type_name: Annotated[str, "Type of the stack variable"] | ||
| ) -> bool: |
| def delete_stack_frame_variable( | ||
| function_address: Annotated[str, "Address of the function to set the stack frame variables"], | ||
| variable_name: Annotated[str, "Name of the stack variable"] | ||
| ) -> bool: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few functions for manipulating IDA stack variables. These are mostly relevant when no decompiler is available, but it will make decompilation better as well (I wish they'd finally unify their type systems!)
I also added a helper function for resolving types by name which handles many of the standard types (it assumes sizeof(int) == 32, sizeof(long) == 32 though).