List imports #85
Open
List imports #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrexodia
requested changes
Jun 11, 2025
| @@ -658,6 +658,44 @@ def list_globals( | |||
| """List all globals in the database (paginated)""" | |||
| return list_globals_filter(offset, count, "") | |||
|
|
|||
| class Import(TypedDict): | |||
| address: str | |||
There was a problem hiding this comment.
The TypedDict does not match the returned data.
| "module": module_name, | ||
| "import": symbol_name, | ||
| "address": f"{ea:#x}", | ||
| "ordinal": f"#{ordinal}" |
There was a problem hiding this comment.
Does the ordinal provide any kind of value? As far as I know this is just what IDA uses as an index to identify that specific import.
| acc += [{ | ||
| "module": module_name, | ||
| "import": symbol_name, | ||
| "address": f"{ea:#x}", |
There was a problem hiding this comment.
Use hex(ea) to match the rest of the codebase
|
|
||
| def imp_cb(ea, symbol_name, ordinal, acc): | ||
| if not symbol_name: | ||
| symbol_name = "<unnamed>" |
There was a problem hiding this comment.
Under what circumstances does this happen? Perhaps this is where we should return symbol_name = f"#{ordinal}" in this case?
|
|
||
| acc += [{ | ||
| "module": module_name, | ||
| "import": symbol_name, |
There was a problem hiding this comment.
I would prefer calling this name or function, or did you observe calling it import improve LLM performance in some way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a paginated
list_imports.Returns data that looks like this:
{ "data": [ { "module": ".dynsym", "import": "sprintf@@GLIBC_2.0", "address": "0x804e580", "ordinal": "0x0" }, { "module": ".dynsym", "import": "err@@GLIBC_2.0", "address": "0x804e584", "ordinal": "0x0" }, { "module": ".dynsym", "import": "signal@@GLIBC_2.0", "address": "0x804e588", "ordinal": "0x0" }, { "module": ".dynsym", "import": "recv@@GLIBC_2.0", "address": "0x804e58c", "ordinal": "0x0" }, { "module": ".dynsym", "import": "calloc@@GLIBC_2.0", "address": "0x804e590", "ordinal": "0x0" }, { "module": ".dynsym", "import": "listen@@GLIBC_2.0", "address": "0x804e594", "ordinal": "0x0" }, { "module": ".dynsym", "import": "__libc_start_main@@GLIBC_2.0", "address": "0x804e598", "ordinal": "0x0" }, { "module": ".dynsym", "import": "htons@@GLIBC_2.0", "address": "0x804e59c", "ordinal": "0x0" }, { "module": ".dynsym", "import": "setegid@@GLIBC_2.0", "address": "0x804e5a0", "ordinal": "0x0" }, { "module": ".dynsym", "import": "read@@GLIBC_2.0", "address": "0x804e5a4", "ordinal": "0x0" }, { "module": ".dynsym", "import": "free@@GLIBC_2.0", "address": "0x804e5a8", "ordinal": "0x0" }, { "module": ".dynsym", "import": "accept@@GLIBC_2.0", "address": "0x804e5ac", "ordinal": "0x0" }, { "module": ".dynsym", "import": "socket@@GLIBC_2.0", "address": "0x804e5b0", "ordinal": "0x0" } ], "next_offset": null }